Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1402453004: Use a WeakPtr to post a create channel task to the IO thread. (Closed)

Created:
5 years, 2 months ago by Anand Mistry (off Chromium)
Modified:
5 years, 2 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a WeakPtr to post a create channel task to the IO thread. For now, the channel manager is passed as a weak pointer argument and CHECK fails. This is a temporary debugging aid to help me understand why ChannelManager has been destroyed at this point. The code will be changed to handle the case gracefully once I know more. BUG=542069 Committed: https://crrev.com/b56f54f4f3b37fa178cb38507b652af17ef62a90 Cr-Commit-Position: refs/heads/master@{#353888}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M third_party/mojo/src/mojo/edk/system/channel_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/system/channel_manager.cc View 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Anand Mistry (off Chromium)
5 years, 2 months ago (2015-10-12 02:58:41 UTC) #2
Ken Rockot(use gerrit already)
lgtm if you still want to land this
5 years, 2 months ago (2015-10-13 16:49:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402453004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402453004/1
5 years, 2 months ago (2015-10-13 21:44:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-13 22:57:39 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 22:58:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b56f54f4f3b37fa178cb38507b652af17ef62a90
Cr-Commit-Position: refs/heads/master@{#353888}

Powered by Google App Engine
This is Rietveld 408576698