Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: chrome/browser/ui/views/layout_constants.cc

Issue 1402453002: Parametrize some more constants that will be changing in MD. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/layout_constants.h ('k') | chrome/browser/ui/views/tabs/tab_strip.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/layout_constants.cc
diff --git a/chrome/browser/ui/views/layout_constants.cc b/chrome/browser/ui/views/layout_constants.cc
index 66ee3fc2f88dfc683d4c6bf6bd401432b774ce4c..008262ae49eff1f3386646a02ad0cbecd9a162c6 100644
--- a/chrome/browser/ui/views/layout_constants.cc
+++ b/chrome/browser/ui/views/layout_constants.cc
@@ -15,6 +15,7 @@ int GetLayoutConstant(LayoutConstant constant) {
const int kLocationBarHeight[] = {0, 28, 32};
const int kLocationBarHorizontalPadding[] = {3, 6, 6};
const int kLocationBarVerticalPadding[] = {2, 2, 2};
+ const int kNewTabButtonWidth[] = {34, 34, 34};
const int kOmniboxDropdownBorderInterior[] = {6, 0, 0};
const int kOmniboxFontPixelSize[] = {16, 14, 14};
const int kTabCloseButtonTrailingPaddingOverlap[] = {2, 2, 2};
@@ -22,8 +23,10 @@ int GetLayoutConstant(LayoutConstant constant) {
const int kTabMaximumTitleWidth[] = {175, 175, 175};
const int kTabPinnedContentWidth[] = {25, 25, 25};
#if defined(OS_MACOSX)
+ const int kTabstripNewTabButtonOverlap[] = {8, 8, 8};
const int kTabstripTabOverlap[] = {19, 19, 19};
#else
+ const int kTabstripNewTabButtonOverlap[] = {11, 11, 11};
const int kTabstripTabOverlap[] = {26, 26, 26};
#endif
const int kTabstripToolbarOverlap[] = {3, 3, 3};
@@ -49,10 +52,14 @@ int GetLayoutConstant(LayoutConstant constant) {
return kLocationBarHorizontalPadding[mode];
case LOCATION_BAR_VERTICAL_PADDING:
return kLocationBarVerticalPadding[mode];
+ case NEW_TAB_BUTTON_WIDTH:
+ return kNewTabButtonWidth[mode];
case OMNIBOX_DROPDOWN_BORDER_INTERIOR:
return kOmniboxDropdownBorderInterior[mode];
case OMNIBOX_FONT_PIXEL_SIZE:
return kOmniboxFontPixelSize[mode];
+ case TABSTRIP_NEW_TAB_BUTTON_OVERLAP:
+ return kTabstripNewTabButtonOverlap[mode];
case TABSTRIP_TAB_OVERLAP:
return kTabstripTabOverlap[mode];
case TABSTRIP_TOOLBAR_OVERLAP:
« no previous file with comments | « chrome/browser/ui/views/layout_constants.h ('k') | chrome/browser/ui/views/tabs/tab_strip.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698