Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1402413005: Rename cdm_adapter to ppapi_cdm_adapter (Closed)

Created:
5 years, 2 months ago by jrummell
Modified:
5 years, 1 month ago
Reviewers:
Sorin Jianu, bbudge, xhwang
CC:
chromium-reviews, yusukes+watch_chromium.org, feature-media-reviews_chromium.org, binji+watch_chromium.org, tzik, eme-reviews_chromium.org, teravest+watch_chromium.org, bradnelson+warch_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename cdm_adapter to ppapi_cdm_adapter As the current cdm_adapter is specific to ppapi, rename it to make it clearer. This also moves some of the generic files out of the ppapi folder so that they can be used by other implementations. TEST=compiles Committed: https://crrev.com/38ae661b252d977ce675140c6e5470204809d0c0 Cr-Commit-Position: refs/heads/master@{#356196}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rename flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -2256 lines) Patch
M chrome/browser/component_updater/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/widevine_cdm_component_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cdm/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + media/cdm/cdm_wrapper.h View 1 11 chunks +51 lines, -62 lines 0 comments Download
M media/cdm/ppapi/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
D media/cdm/ppapi/cdm_adapter.h View 1 chunk +0 lines, -291 lines 0 comments Download
D media/cdm/ppapi/cdm_adapter.cc View 1 chunk +0 lines, -1349 lines 0 comments Download
D media/cdm/ppapi/cdm_adapter.gni View 1 chunk +0 lines, -52 lines 0 comments Download
D media/cdm/ppapi/cdm_wrapper.h View 1 chunk +0 lines, -316 lines 0 comments Download
A + media/cdm/ppapi/ppapi_cdm_adapter.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + media/cdm/ppapi/ppapi_cdm_adapter.cc View 31 chunks +69 lines, -109 lines 0 comments Download
A + media/cdm/ppapi/ppapi_cdm_adapter.gni View 1 2 chunks +6 lines, -5 lines 0 comments Download
D media/cdm/ppapi/supported_cdm_versions.h View 1 chunk +0 lines, -52 lines 0 comments Download
A + media/cdm/supported_cdm_versions.h View 4 chunks +5 lines, -5 lines 0 comments Download
M media/media_cdm_adapter.gyp View 1 1 chunk +8 lines, -5 lines 0 comments Download
M third_party/widevine/cdm/BUILD.gn View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
jrummell
PTAL. Just moving/renaming files. All the formatting changes are due to clang-format.
5 years, 2 months ago (2015-10-23 00:24:07 UTC) #2
xhwang
lgtm with one suggestion https://chromiumcodereview.appspot.com/1402413005/diff/1/media/cdm/cdm_wrapper.h File media/cdm/cdm_wrapper.h (right): https://chromiumcodereview.appspot.com/1402413005/diff/1/media/cdm/cdm_wrapper.h#newcode14 media/cdm/cdm_wrapper.h:14: #if defined(PLUGIN_IMPLEMENTATION) Thinking it again ...
5 years, 2 months ago (2015-10-23 17:15:29 UTC) #3
jrummell
+mal@ for changes in chrome/browser/component_updater/. The change is simply an included file moved directories. https://codereview.chromium.org/1402413005/diff/1/media/cdm/cdm_wrapper.h ...
5 years, 2 months ago (2015-10-23 23:41:36 UTC) #5
jrummell
-mal@, +sorin@ for changes in chrome/browser/component_updater/. The change is simply an included file moved directories.
5 years, 2 months ago (2015-10-23 23:54:10 UTC) #7
Sorin Jianu
lgtm Thank you! component updater lgtm
5 years, 2 months ago (2015-10-24 01:23:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402413005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402413005/20001
5 years, 1 month ago (2015-10-26 20:48:48 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/112754)
5 years, 1 month ago (2015-10-26 20:59:18 UTC) #13
jrummell
+bbudge@ for OWNERS review of DEPS change (media/cdm/DEPS). Moved cdm_wrapper.h from media/cdm/ppapi to media/cdm, but ...
5 years, 1 month ago (2015-10-26 21:26:48 UTC) #15
bbudge
media/cdm/DEPS LGTM
5 years, 1 month ago (2015-10-26 23:17:44 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402413005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402413005/20001
5 years, 1 month ago (2015-10-26 23:40:15 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-27 00:20:14 UTC) #19
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 00:20:56 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/38ae661b252d977ce675140c6e5470204809d0c0
Cr-Commit-Position: refs/heads/master@{#356196}

Powered by Google App Engine
This is Rietveld 408576698