Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: scripts/master/log_parser/process_log.py

Issue 14024008: Update GraphingPageCyclerLogProcessor to work with updated Telemetry pagecyclers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/master/unittests/data/page_cycler.log » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/master/log_parser/process_log.py
===================================================================
--- scripts/master/log_parser/process_log.py (revision 193793)
+++ scripts/master/log_parser/process_log.py (working copy)
@@ -951,6 +951,15 @@
<revision>_<tracename>.dat holding a line of times for each URL loaded,
for use by humans when debugging a regression.
"""
+
+ # If the name of the trace is one of the pages in the page list then we are
+ # dealing with the results for that page only, not the overall results. So
+ # calculate the statistics like a normal GraphingLogProcessor, not the
+ # GraphingPageCyclerLogProcessor.
+ if trace_name in self._page_list:
+ return super(GraphingPageCyclerLogProcessor, self)._CalculateStatistics(
+ value_list, trace_name)
+
sums = []
page_times = {}
page_count = len(self._page_list)
« no previous file with comments | « no previous file | scripts/master/unittests/data/page_cycler.log » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698