Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1402393003: Ensure JSProxy correctness for PrototypeIterator uses (Closed)

Created:
5 years, 1 month ago by Jakob Kummerow
Modified:
5 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ensure JSProxy correctness for PrototypeIterator uses This CL fixes an invalid cast in Slow_ArrayConcat (a Proxy on a DICTIONARY_ELEMENTS array's prototype chain). It also adds some comments and minor drive-by refactorings to other PrototypeIterator use sites. R=verwaest@chromium.org Committed: https://crrev.com/48f4cbc7c3503a934f89b7cd2b9e8878795123ba Cr-Commit-Position: refs/heads/master@{#31738}

Patch Set 1 #

Patch Set 2 : reword comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -20 lines) Patch
M src/api.cc View 3 chunks +14 lines, -14 lines 0 comments Download
M src/builtins.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ic/handler-compiler.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.cc View 2 chunks +4 lines, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 4 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jakob Kummerow
5 years, 1 month ago (2015-11-02 16:02:05 UTC) #1
Toon Verwaest
lgtm
5 years, 1 month ago (2015-11-03 09:44:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402393003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402393003/20001
5 years, 1 month ago (2015-11-03 10:18:51 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-03 10:43:10 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 10:43:47 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/48f4cbc7c3503a934f89b7cd2b9e8878795123ba
Cr-Commit-Position: refs/heads/master@{#31738}

Powered by Google App Engine
This is Rietveld 408576698