Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1402373007: [sql] Increase database chunk size for large databases. (Closed)

Created:
5 years, 1 month ago by Scott Hess - ex-Googler
Modified:
5 years, 1 month ago
Reviewers:
rmcilroy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sql] Increase database chunk size for large databases. SQLite implements a hint to request the databases be truncated or expanded to multiples of a chunk size. This was originally implemented to reduce filesystem fragmentation, and it also can improve performance because file sizes don't vary as much. For a memory-mapped database, it also reduces the number of calls to adjust the memory map when the database size changes. BUG=551108 Committed: https://crrev.com/5dac334f21d99d9f97d9c7bbfbba40c8e872545b Cr-Commit-Position: refs/heads/master@{#358121}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
M sql/connection.cc View 1 3 chunks +28 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
Scott Hess - ex-Googler
5 years, 1 month ago (2015-11-04 23:37:29 UTC) #2
rmcilroy
lgtm
5 years, 1 month ago (2015-11-05 11:39:30 UTC) #3
Scott Hess - ex-Googler
rebase
5 years, 1 month ago (2015-11-05 18:50:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402373007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402373007/20001
5 years, 1 month ago (2015-11-05 19:04:12 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/140929) linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 1 month ago (2015-11-05 19:16:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402373007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402373007/20001
5 years, 1 month ago (2015-11-05 19:21:10 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/136673)
5 years, 1 month ago (2015-11-05 19:36:36 UTC) #13
Scott Hess - ex-Googler
On 2015/11/05 19:36:36, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 1 month ago (2015-11-05 20:09:42 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402373007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402373007/20001
5 years, 1 month ago (2015-11-05 20:10:01 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-05 20:47:49 UTC) #17
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 20:48:36 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5dac334f21d99d9f97d9c7bbfbba40c8e872545b
Cr-Commit-Position: refs/heads/master@{#358121}

Powered by Google App Engine
This is Rietveld 408576698