Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(990)

Side by Side Diff: net/spdy/buffered_spdy_framer.cc

Issue 1402373005: Remove description from HTTP/2 RST_STREAM. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/quic_headers_stream_test.cc ('k') | net/spdy/spdy_framer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/spdy/buffered_spdy_framer.h" 5 #include "net/spdy/buffered_spdy_framer.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 8
9 namespace net { 9 namespace net {
10 10
(...skipping 325 matching lines...) Expand 10 before | Expand all | Expand 10 after
336 // TODO(hkhalil): Avoid copy here. 336 // TODO(hkhalil): Avoid copy here.
337 syn_reply.set_header_block(*headers); 337 syn_reply.set_header_block(*headers);
338 return spdy_framer_.SerializeSynReply(syn_reply); 338 return spdy_framer_.SerializeSynReply(syn_reply);
339 } 339 }
340 340
341 // TODO(jgraettinger): Eliminate uses of this method (prefer 341 // TODO(jgraettinger): Eliminate uses of this method (prefer
342 // SpdyRstStreamIR). 342 // SpdyRstStreamIR).
343 SpdyFrame* BufferedSpdyFramer::CreateRstStream( 343 SpdyFrame* BufferedSpdyFramer::CreateRstStream(
344 SpdyStreamId stream_id, 344 SpdyStreamId stream_id,
345 SpdyRstStreamStatus status) const { 345 SpdyRstStreamStatus status) const {
346 // RST_STREAM payloads are not part of any SPDY spec. 346 SpdyRstStreamIR rst_ir(stream_id, status);
347 // SpdyFramer will accept them, but don't create them.
348 SpdyRstStreamIR rst_ir(stream_id, status, "");
349 return spdy_framer_.SerializeRstStream(rst_ir); 347 return spdy_framer_.SerializeRstStream(rst_ir);
350 } 348 }
351 349
352 // TODO(jgraettinger): Eliminate uses of this method (prefer 350 // TODO(jgraettinger): Eliminate uses of this method (prefer
353 // SpdySettingsIR). 351 // SpdySettingsIR).
354 SpdyFrame* BufferedSpdyFramer::CreateSettings( 352 SpdyFrame* BufferedSpdyFramer::CreateSettings(
355 const SettingsMap& values) const { 353 const SettingsMap& values) const {
356 SpdySettingsIR settings_ir; 354 SpdySettingsIR settings_ir;
357 for (SettingsMap::const_iterator it = values.begin(); 355 for (SettingsMap::const_iterator it = values.begin();
358 it != values.end(); 356 it != values.end();
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
435 433
436 void BufferedSpdyFramer::InitHeaderStreaming(SpdyStreamId stream_id) { 434 void BufferedSpdyFramer::InitHeaderStreaming(SpdyStreamId stream_id) {
437 memset(header_buffer_, 0, kHeaderBufferSize); 435 memset(header_buffer_, 0, kHeaderBufferSize);
438 header_buffer_used_ = 0; 436 header_buffer_used_ = 0;
439 header_buffer_valid_ = true; 437 header_buffer_valid_ = true;
440 header_stream_id_ = stream_id; 438 header_stream_id_ = stream_id;
441 DCHECK_NE(header_stream_id_, SpdyFramer::kInvalidStream); 439 DCHECK_NE(header_stream_id_, SpdyFramer::kInvalidStream);
442 } 440 }
443 441
444 } // namespace net 442 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/quic_headers_stream_test.cc ('k') | net/spdy/spdy_framer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698