Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1402373005: Remove description from HTTP/2 RST_STREAM. (Closed)

Created:
5 years, 1 month ago by Bence
Modified:
5 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove description from HTTP/2 RST_STREAM. Remove |description| from class SpdyRstStreamIR and SpdyFramer::SerializeRstStream(), because it is forbidden by HTTP/2 specs. This CL lands server change 106512729 by bnc. BUG=548674 Committed: https://crrev.com/31bb6eef8786a9c8847fcc7850db367c751af194 Cr-Commit-Position: refs/heads/master@{#357082}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -38 lines) Patch
M net/quic/quic_headers_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/buffered_spdy_framer.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/spdy/spdy_framer.cc View 3 chunks +2 lines, -12 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 4 chunks +6 lines, -12 lines 0 comments Download
M net/spdy/spdy_protocol.h View 2 chunks +1 line, -5 lines 0 comments Download
M net/spdy/spdy_protocol.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M net/spdy/spdy_test_util_common.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Bence
Ryan: PTAL. Thank you.
5 years, 1 month ago (2015-10-29 18:14:38 UTC) #3
Ryan Hamilton
lgtm
5 years, 1 month ago (2015-10-29 20:01:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402373005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402373005/1
5 years, 1 month ago (2015-10-30 11:32:16 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 11:36:39 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 11:37:47 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/31bb6eef8786a9c8847fcc7850db367c751af194
Cr-Commit-Position: refs/heads/master@{#357082}

Powered by Google App Engine
This is Rietveld 408576698