Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1402373002: [test] Set default locale in test runner (Closed)

Created:
5 years, 2 months ago by Michael Achenbach
Modified:
4 years, 8 months ago
CC:
hinoka, M-A Ruel, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Set default locale in test runner BUG=v8:4437, v8:2899, chromium:604310 LOG=n Committed: https://crrev.com/9c927d0f01acd5b8e6029b0eea0cca41b8e66973 Cr-Commit-Position: refs/heads/master@{#35614}

Patch Set 1 #

Patch Set 2 : Remove expectations #

Patch Set 3 : Remove mac expectation #

Patch Set 4 : English interface in env #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -39 lines) Patch
M test/intl/intl.status View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M test/test262/test262.status View 1 2 2 chunks +0 lines, -21 lines 0 comments Download
M tools/run-tests.py View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Michael Achenbach
PTAL Patch 2 and 3 show that the issue still reproduces for mac and linux ...
4 years, 8 months ago (2016-04-19 10:07:03 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402373002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402373002/60001
4 years, 8 months ago (2016-04-19 10:07:21 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-19 10:09:30 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-19 10:27:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402373002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402373002/60001
4 years, 8 months ago (2016-04-19 11:23:47 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-19 11:26:29 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 11:27:14 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9c927d0f01acd5b8e6029b0eea0cca41b8e66973
Cr-Commit-Position: refs/heads/master@{#35614}

Powered by Google App Engine
This is Rietveld 408576698