Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1402363014: Created PNaCl translation documenation and updated old NaCl documents. (Closed)

Created:
5 years, 1 month ago by Sean Klein
Modified:
5 years, 1 month ago
Reviewers:
Petr Hosek
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Created PNaCl translation documenation and updated old NaCl documents. BUG=#396 R=phosek@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2f78afbbf58caa19fcc1688176921e32bb16e3a2

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added note for android #

Patch Set 3 : #

Total comments: 10

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -15 lines) Patch
M mojo/nacl/nonsfi/README.md View 1 2 3 4 chunks +47 lines, -15 lines 0 comments Download
A services/nacl/README.md View 1 2 3 1 chunk +73 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Sean Klein
5 years, 1 month ago (2015-11-10 01:22:04 UTC) #2
Petr Hosek
Since this is Markdown, I'd put `` around all identifiers. https://codereview.chromium.org/1402363014/diff/1/mojo/nacl/nonsfi/README.md File mojo/nacl/nonsfi/README.md (right): https://codereview.chromium.org/1402363014/diff/1/mojo/nacl/nonsfi/README.md#newcode31 ...
5 years, 1 month ago (2015-11-11 17:26:17 UTC) #3
Sean Klein
https://codereview.chromium.org/1402363014/diff/40001/services/nacl/README.md File services/nacl/README.md (right): https://codereview.chromium.org/1402363014/diff/40001/services/nacl/README.md#newcode25 services/nacl/README.md:25: in structure to the Non-SFI Nexe content handler, it ...
5 years, 1 month ago (2015-11-11 18:46:24 UTC) #4
Sean Klein
5 years, 1 month ago (2015-11-11 18:46:25 UTC) #5
Petr Hosek
lgtm
5 years, 1 month ago (2015-11-11 18:58:02 UTC) #6
Sean Klein
5 years, 1 month ago (2015-11-11 18:59:08 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
2f78afbbf58caa19fcc1688176921e32bb16e3a2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698