Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4378)

Unified Diff: chrome/browser/ui/views/location_bar/zoom_bubble_view.h

Issue 1402363013: Update location bar bubble/icon behavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/zoom_bubble_view.h
diff --git a/chrome/browser/ui/views/location_bar/zoom_bubble_view.h b/chrome/browser/ui/views/location_bar/zoom_bubble_view.h
index acf2d34ad22af4a27d6b9fe89ef4e39f964d04b5..3d179916327f65a3aa1a5f5ae9033a853453389c 100644
--- a/chrome/browser/ui/views/location_bar/zoom_bubble_view.h
+++ b/chrome/browser/ui/views/location_bar/zoom_bubble_view.h
@@ -36,9 +36,9 @@ class ZoomBubbleView : public LocationBarBubbleDelegateView,
public extensions::IconImage::Observer {
public:
// Shows the bubble and automatically closes it after a short time period if
- // |auto_close| is true.
+ // |reason| is AUTOMATIC.
static void ShowBubble(content::WebContents* web_contents,
- bool auto_close);
+ DisplayReason reason);
// Closes the showing bubble (if one exists).
static void CloseBubble();
@@ -71,7 +71,7 @@ class ZoomBubbleView : public LocationBarBubbleDelegateView,
ZoomBubbleView(views::View* anchor_view,
content::WebContents* web_contents,
- bool auto_close,
+ DisplayReason reason,
ImmersiveModeController* immersive_mode_controller);
~ZoomBubbleView() override;
@@ -115,7 +115,7 @@ class ZoomBubbleView : public LocationBarBubbleDelegateView,
// twice at the same time.
static ZoomBubbleView* zoom_bubble_;
- // Timer used to close the bubble when |auto_close_| is true.
+ // Timer used to auto close the bubble.
base::OneShotTimer timer_;
// Image button in the zoom bubble that will show the |extension_icon_| image
« no previous file with comments | « chrome/browser/ui/views/location_bar/location_bar_view.cc ('k') | chrome/browser/ui/views/location_bar/zoom_bubble_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698