chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc - Issue 1402363013: Update location bar bubble/icon behavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc

Issue 1402363013: Update location bar bubble/icon behavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h ('k') | chrome/browser/ui/views/location_bar/location_bar_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc

diff --git a/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc b/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc

index 18f29536f52c92f1a060e380aaad152bf16ffe04..2fa92b58fd8bf1357a0a456448cbe0bad3763593 100644

--- a/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc

+++ b/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc

@@ -29,6 +29,15 @@ LocationBarBubbleDelegateView::LocationBarBubbleDelegateView(

LocationBarBubbleDelegateView::~LocationBarBubbleDelegateView() {}

+void LocationBarBubbleDelegateView::ShowForReason(DisplayReason reason) {

+ if (reason == USER_GESTURE) {

+ SetArrowPaintType(views::BubbleBorder::PAINT_TRANSPARENT);

+ GetWidget()->Show();

+ } else {

+ GetWidget()->ShowInactive();

+ }

void LocationBarBubbleDelegateView::Observe(

int type,

const content::NotificationSource& source,