Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3659)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 1402363013: Update location bar bubble/icon behavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index 2464dad26453209721fe259b0968849f59c33153..5be1927004853e3f1be96b09cca6cd2573717053 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -856,7 +856,7 @@ void BrowserView::SetStarredState(bool is_starred) {
}
void BrowserView::SetTranslateIconToggled(bool is_lit) {
- GetLocationBarView()->SetTranslateIconToggled(is_lit);
+ // Translate icon is never active on Views.
}
void BrowserView::OnActiveTabChanged(content::WebContents* old_contents,
@@ -1281,11 +1281,13 @@ void BrowserView::ShowBookmarkAppBubble(
autofill::SaveCardBubbleView* BrowserView::ShowSaveCreditCardBubble(
content::WebContents* web_contents,
- autofill::SaveCardBubbleController* controller) {
- autofill::SaveCardBubbleView* view = new autofill::SaveCardBubbleViews(
+ autofill::SaveCardBubbleController* controller,
+ bool is_user_gesture) {
+ autofill::SaveCardBubbleViews* view = new autofill::SaveCardBubbleViews(
GetToolbarView()->GetSaveCreditCardBubbleAnchor(), web_contents,
controller);
- view->Show();
+ view->Show(is_user_gesture ? autofill::SaveCardBubbleViews::USER_GESTURE
+ : autofill::SaveCardBubbleViews::AUTOMATIC);
return view;
}
@@ -1312,7 +1314,8 @@ void BrowserView::ShowTranslateBubble(
TranslateBubbleView::ShowBubble(
GetToolbarView()->GetTranslateBubbleAnchor(), web_contents, step,
- error_type, is_user_gesture);
+ error_type, is_user_gesture ? TranslateBubbleView::USER_GESTURE
+ : TranslateBubbleView::AUTOMATIC);
}
bool BrowserView::IsProfileResetBubbleSupported() const {
« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.h ('k') | chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698