Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Side by Side Diff: chrome/browser/ui/views/passwords/manage_passwords_icon_views.cc

Issue 1402363013: Update location bar bubble/icon behavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/passwords/manage_passwords_icon_views.h" 5 #include "chrome/browser/ui/views/passwords/manage_passwords_icon_views.h"
6 6
7 #include "chrome/app/chrome_command_ids.h" 7 #include "chrome/app/chrome_command_ids.h"
8 #include "chrome/browser/command_updater.h" 8 #include "chrome/browser/command_updater.h"
9 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h" 9 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
10 #include "chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h" 10 #include "chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h"
11 #include "chrome/grit/generated_resources.h" 11 #include "chrome/grit/generated_resources.h"
12 #include "components/password_manager/core/common/password_manager_ui.h" 12 #include "components/password_manager/core/common/password_manager_ui.h"
13 #include "ui/base/l10n/l10n_util.h" 13 #include "ui/base/l10n/l10n_util.h"
14 #include "ui/base/resource/resource_bundle.h" 14 #include "ui/base/resource/resource_bundle.h"
15 #include "ui/gfx/vector_icons_public.h" 15 #include "ui/gfx/vector_icons_public.h"
16 16
17 ManagePasswordsIconViews::ManagePasswordsIconViews(CommandUpdater* updater) 17 ManagePasswordsIconViews::ManagePasswordsIconViews(CommandUpdater* updater)
18 : BubbleIconView(updater, IDC_MANAGE_PASSWORDS_FOR_PAGE), 18 : BubbleIconView(updater, IDC_MANAGE_PASSWORDS_FOR_PAGE),
19 state_(password_manager::ui::INACTIVE_STATE) { 19 state_(password_manager::ui::INACTIVE_STATE) {
20 SetFocusable(true); 20 SetFocusable(true);
21 UpdateUiForState(); 21 UpdateUiForState();
22 } 22 }
23 23
24 ManagePasswordsIconViews::~ManagePasswordsIconViews() {} 24 ManagePasswordsIconViews::~ManagePasswordsIconViews() {}
25 25
26 void ManagePasswordsIconViews::SetActive(bool active) {
27 SetActiveInternal(active);
28 }
29
30 void ManagePasswordsIconViews::SetState(password_manager::ui::State state) { 26 void ManagePasswordsIconViews::SetState(password_manager::ui::State state) {
31 if (state_ == state) 27 if (state_ == state)
32 return; 28 return;
33 // If there is an opened bubble for the current icon it should go away. 29 // If there is an opened bubble for the current icon it should go away.
34 if (active()) 30 if (active())
35 ManagePasswordsBubbleView::CloseBubble(); 31 ManagePasswordsBubbleView::CloseBubble();
36 state_ = state; 32 state_ = state;
37 UpdateUiForState(); 33 UpdateUiForState();
38 } 34 }
39 35
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 82
87 gfx::VectorIconId ManagePasswordsIconViews::GetVectorIcon() const { 83 gfx::VectorIconId ManagePasswordsIconViews::GetVectorIcon() const {
88 return gfx::VectorIconId::AUTOLOGIN; 84 return gfx::VectorIconId::AUTOLOGIN;
89 } 85 }
90 86
91 void ManagePasswordsIconViews::AboutToRequestFocusFromTabTraversal( 87 void ManagePasswordsIconViews::AboutToRequestFocusFromTabTraversal(
92 bool reverse) { 88 bool reverse) {
93 if (active()) 89 if (active())
94 ManagePasswordsBubbleView::ActivateBubble(); 90 ManagePasswordsBubbleView::ActivateBubble();
95 } 91 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698