[Atom] Issue 424. Fix for 'getNavigation' and index expressions.

[Atom] Issue 424. Fix for 'getNavigation' and index expressions.

R=brianwilkerson@google.com
BUG= https://github.com/dart-atom/dartlang/issues/424

Committed: https://github.com/dart-lang/sdk/commit/289bd0a056abb17587a692fd9b1f5f02190139e5

[Brian Wilkerson, 2015-10-25 15:28:04]

LGTM

https://codereview.chromium.org/1402353009/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/domains/analysis/navigation_dart.dart (right):

https://codereview.chromium.org/1402353009/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/domains/analysis/navigation_dart.dart:332: while
(_isNodeInRange(node)) {
I don't understand this while loop, so I'm probably misunderstanding something.

This `visitNode` method has already been invoked on all of the parents of the
`node`, and if any of them had been in range we would not have invoked this
method on any of their children. Therefore, `node` is the highest level node for
which `_isNodeInRange` will return `true`. Therefore, the body of this while
loop will always be executed exactly once, and the `visitor` will always visit a
node that is not in range. At the very least it seems like lines 332 - 335 could
be replaced by:

    node.parent.accept(visitor);

(And if the loop really is necessary, don't we need to guard against running off
the top of the AST structure and having `node` be set to `null`?)

[scheglov, 2015-10-25 18:29:44]

https://codereview.chromium.org/1402353009/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/domains/analysis/navigation_dart.dart (right):

https://codereview.chromium.org/1402353009/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/domains/analysis/navigation_dart.dart:332: while
(_isNodeInRange(node)) {
Thank you.
Reworked.

[scheglov, 2015-10-25 18:29:59]

Committed patchset #1 (id:1) manually as
289bd0a056abb17587a692fd9b1f5f02190139e5 (presubmit successful).