Issue 1402353007: Remove weak symbol redefinitions when building on linux with gcc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1402353007: Remove weak symbol redefinitions when building on linux with gcc. (Closed)

Created:
5 years, 2 months ago by cdotstout

Modified:
5 years, 2 months ago

Reviewers:
jamesr, viettrungluu

CC:
mojo-reviews_chromium.org

Base URL:
https://github.com/domokit/mojo.git@ozonebuildfix

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Remove weak symbol redefinitions when building on linux with gcc. Causes a problem with fnl/musl due to #define of pthread_equal. I think these aren't needed. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e799ecc91a24e8ad969b77d8a666c992cfe7c7e6

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -43 lines)			Patch
	M	third_party/libxml/src/threads.c	View		1 chunk	+1 line, -43 lines	0 comments	Download

Depends on Patchset:

Total messages: 6 (1 generated)

jamesr

GN says it's just the base test support library for formatting XML output. We can ...

5 years, 2 months ago (2015-10-21 18:23:09 UTC) #4

jamesr

Hmm, ripping it out is more involved (it uses XML for IPC). this lgtm - ...

5 years, 2 months ago (2015-10-21 18:30:55 UTC) #5

cdotstout

5 years, 2 months ago (2015-10-21 18:49:09 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e799ecc91a24e8ad969b77d8a666c992cfe7c7e6 (presubmit successful).