Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1402353006: [test] Differentiate between exhaustive and default testing variants. (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Differentiate between exhaustive and default testing variants. Committed: https://crrev.com/58befc9b817ce3e03bb4f5b04411b61ff66d4c84 Cr-Commit-Position: refs/heads/master@{#31409}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -5 lines) Patch
M test/cctest/cctest.status View 1 chunk +20 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +8 lines, -0 lines 0 comments Download
M tools/run-tests.py View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/testrunner/local/testsuite.py View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402353006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402353006/20001
5 years, 2 months ago (2015-10-20 12:34:31 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-20 12:44:05 UTC) #8
Michael Achenbach
lgtm - but it would be nice if the NO_VARIANTS modifiers don't stay too long ...
5 years, 2 months ago (2015-10-20 13:09:56 UTC) #10
Benedikt Meurer
On 2015/10/20 13:09:56, Michael Achenbach wrote: > lgtm - but it would be nice if ...
5 years, 2 months ago (2015-10-20 13:13:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402353006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402353006/20001
5 years, 2 months ago (2015-10-20 13:13:54 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 2 months ago (2015-10-20 13:16:37 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/58befc9b817ce3e03bb4f5b04411b61ff66d4c84 Cr-Commit-Position: refs/heads/master@{#31409}
5 years, 2 months ago (2015-10-20 13:17:07 UTC) #15
Jarin
5 years, 2 months ago (2015-10-20 13:19:20 UTC) #16
Message was sent while issue was closed.
On 2015/10/20 13:13:54, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1402353006/20001
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1402353006/20001

Powered by Google App Engine
This is Rietveld 408576698