Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1118)

Unified Diff: util/win/exception_handler_server_test.cc

Issue 1402333004: win: Construct ExceptionHandlerServer() with its pipe argument (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: util/win/exception_handler_server_test.cc
diff --git a/util/win/exception_handler_server_test.cc b/util/win/exception_handler_server_test.cc
index 0d87086b8d7ac0f94f9cc626dcb39c8a117c7550..9fe593b5b155c68f72f047eb2dd6a930e031c4d7 100644
--- a/util/win/exception_handler_server_test.cc
+++ b/util/win/exception_handler_server_test.cc
@@ -36,20 +36,18 @@ namespace {
// Runs the ExceptionHandlerServer on a background thread.
class RunServerThread : public Thread {
public:
- // Instantiates a thread which will invoke server->Run(delegate, pipe_name).
+ // Instantiates a thread which will invoke server->Run(delegate).
RunServerThread(ExceptionHandlerServer* server,
- ExceptionHandlerServer::Delegate* delegate,
- const std::string& pipe_name)
- : server_(server), delegate_(delegate), pipe_name_(pipe_name) {}
+ ExceptionHandlerServer::Delegate* delegate)
+ : server_(server), delegate_(delegate) {}
~RunServerThread() override {}
private:
// Thread:
- void ThreadMain() override { server_->Run(delegate_, pipe_name_); }
+ void ThreadMain() override { server_->Run(delegate_); }
ExceptionHandlerServer* server_;
ExceptionHandlerServer::Delegate* delegate_;
- std::string pipe_name_;
DISALLOW_COPY_AND_ASSIGN(RunServerThread);
};
@@ -85,8 +83,8 @@ class ExceptionHandlerServerTest : public testing::Test {
base::StringPrintf("%08x", GetCurrentProcessId())),
server_ready_(CreateEvent(nullptr, false, false, nullptr)),
delegate_(server_ready_.get()),
- server_(),
- server_thread_(&server_, &delegate_, pipe_name_) {}
+ server_(pipe_name_),
+ server_thread_(&server_, &delegate_) {}
TestDelegate& delegate() { return delegate_; }
ExceptionHandlerServer& server() { return server_; }
« util/win/exception_handler_server.cc ('K') | « util/win/exception_handler_server.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698