Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 1402333004: win: Construct ExceptionHandlerServer() with its pipe argument (Closed)

Created:
5 years, 1 month ago by Mark Mentovai
Modified:
5 years, 1 month ago
Reviewers:
scottmg
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

win: Construct ExceptionHandlerServer() with its pipe argument This allows better code sharing in crashpad_handler’s main(). It doesn’t look like much of an improvement now, but a separate change will cause the Mac ExceptionHandlerServer() to be constructed with an argument. It will be beneficial for Mac and Windows to be able to share the Run() call. R=scottmg@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/9d03d54d0ba1aa19d90ee226bb6fec9f901d2725

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -34 lines) Patch
M handler/main.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M snapshot/win/exception_snapshot_win_test.cc View 3 chunks +7 lines, -11 lines 0 comments Download
M util/win/exception_handler_server.h View 2 chunks +7 lines, -4 lines 0 comments Download
M util/win/exception_handler_server.cc View 3 chunks +6 lines, -6 lines 1 comment Download
M util/win/exception_handler_server_test.cc View 2 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
https://codereview.chromium.org/1402333004/diff/1/util/win/exception_handler_server.cc File util/win/exception_handler_server.cc (right): https://codereview.chromium.org/1402333004/diff/1/util/win/exception_handler_server.cc#newcode314 util/win/exception_handler_server.cc:314: SendToCrashHandlerServer(pipe_name_16, Saved a conversion here, too.
5 years, 1 month ago (2015-10-29 18:46:46 UTC) #2
scottmg
lgtm
5 years, 1 month ago (2015-10-29 18:52:37 UTC) #3
Mark Mentovai
5 years, 1 month ago (2015-10-29 19:12:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9d03d54d0ba1aa19d90ee226bb6fec9f901d2725 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698