Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1262)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1402333002: fix for C version of YUV to RGB for Arm (Closed)

Created:
5 years, 2 months ago by fbarchard1
Modified:
5 years, 2 months ago
Reviewers:
harryjin, fbarchard
CC:
xhwang
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

fix for C version of YUV to RGB for Arm YuvPixel for arm was miscomputing YG. TBR=harryjin@google.com BUG=libyuv:506 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/52a55049501bdeb7884ac4ea7e7eb4227a0efb13

Patch Set 1 #

Patch Set 2 : move code up to where macros are defined #

Patch Set 3 : switch to variables but with asserts #

Patch Set 4 : the YuvPixel bug was YG #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -40 lines) Patch
M README.chromium View 1 2 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/version.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M source/row_common.cc View 1 2 3 2 chunks +39 lines, -38 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
fbarchard
With this code, arm unittests pass for BT601. BT709 and jpeg fail, since it hard ...
5 years, 2 months ago (2015-10-15 18:42:42 UTC) #2
fbarchard1
5 years, 2 months ago (2015-10-15 19:43:43 UTC) #3
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
52a55049501bdeb7884ac4ea7e7eb4227a0efb13 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698