Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1402313002: add gflags to deps to allow command line parameters. (Closed)

Created:
5 years, 2 months ago by fbarchard1
Modified:
5 years, 2 months ago
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

add gflags to deps to allow command line parameters. unittests currently use environment variables to change behavior. using gflags this can be done via command line. R=kjellander@chromium.org BUG=libyuv:507 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/2dd3d9230ee663e71ed4ad9164033ed672e571de

Patch Set 1 #

Total comments: 4

Patch Set 2 : remove have jpeg test which is just a printf #

Total comments: 1

Patch Set 3 : synced to head #

Patch Set 4 : bump version number to r1513 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M DEPS View 1 1 chunk +10 lines, -0 lines 0 comments Download
M README.chromium View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/version.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
fbarchard1
5 years, 2 months ago (2015-10-15 17:31:59 UTC) #1
kjellander_chromium
Changed to my chromium.org address... https://codereview.chromium.org/1402313002/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/1402313002/diff/1/DEPS#newcode15 DEPS:15: # When rolling gflags, ...
5 years, 2 months ago (2015-10-15 19:29:50 UTC) #3
fbarchard
https://codereview.chromium.org/1402313002/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/1402313002/diff/1/DEPS#newcode15 DEPS:15: # When rolling gflags, also update On 2015/10/15 19:29:49, ...
5 years, 2 months ago (2015-10-15 23:26:06 UTC) #5
kjellander_chromium
lgtm, but please move the test change to another CL. https://codereview.chromium.org/1402313002/diff/20001/unit_test/convert_test.cc File unit_test/convert_test.cc (left): https://codereview.chromium.org/1402313002/diff/20001/unit_test/convert_test.cc#oldcode1451 ...
5 years, 2 months ago (2015-10-16 10:05:27 UTC) #6
fbarchard1
5 years, 2 months ago (2015-10-16 17:57:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
2dd3d9230ee663e71ed4ad9164033ed672e571de (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698