[chromedriver] Fix bugs in SendKeys.

[chromedriver] Fix bugs in SendKeys.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194691

[kkania, 2013-04-15 21:35:35]

lgtm

https://codereview.chromium.org/14023006/diff/1006/chrome/test/chromedriver/k...
File chrome/test/chromedriver/key_converter.cc (right):

https://codereview.chromium.org/14023006/diff/1006/chrome/test/chromedriver/k...
chrome/test/chromedriver/key_converter.cc:102: bool IsPrintable(ui::KeyboardCode
key_code) {
How about rename this IsSpecialKeyPrintable?

https://codereview.chromium.org/14023006/diff/1006/chrome/test/chromedriver/k...
chrome/test/chromedriver/key_converter.cc:269: modified_text = unmodified_text =
"";
Explain why this is needed, perhaps give an example.  We probably want to remove
this once we route the event through the browser instead of the renderer, since
this code isn't actually correct...

https://codereview.chromium.org/14023006/diff/1006/chrome/test/chromedriver/k...
chrome/test/chromedriver/key_converter.cc:290: unmodified_text.clear();
explain why this is needed, perhaps give an example

[chrisgao (Use stgao instead), 2013-04-15 23:57:01]

also enable those passed tests for typing.

https://codereview.chromium.org/14023006/diff/1006/chrome/test/chromedriver/k...
File chrome/test/chromedriver/key_converter.cc (right):

https://codereview.chromium.org/14023006/diff/1006/chrome/test/chromedriver/k...
chrome/test/chromedriver/key_converter.cc:102: bool IsPrintable(ui::KeyboardCode
key_code) {
On 2013/04/15 21:35:35, kkania wrote:
> How about rename this IsSpecialKeyPrintable?

Done.

https://codereview.chromium.org/14023006/diff/1006/chrome/test/chromedriver/k...
chrome/test/chromedriver/key_converter.cc:269: modified_text = unmodified_text =
"";
On 2013/04/15 21:35:35, kkania wrote:
> Explain why this is needed, perhaps give an example.  We probably want to
remove
> this once we route the event through the browser instead of the renderer,
since
> this code isn't actually correct...

Done.

https://codereview.chromium.org/14023006/diff/1006/chrome/test/chromedriver/k...
chrome/test/chromedriver/key_converter.cc:290: unmodified_text.clear();
On 2013/04/15 21:35:35, kkania wrote:
> explain why this is needed, perhaps give an example

Done.

[chrisgao (Use stgao instead), 2013-04-17 21:41:57]

Committed patchset #5 manually as r194691 (presubmit successful).