Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1402233002: Move make_dart_rectangle to html_common (Closed)

Created:
5 years, 2 months ago by Alan Knight
Modified:
5 years, 2 months ago
Reviewers:
terry
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move make_dart_rectangle to html_common BUG= Committed: https://github.com/dart-lang/sdk/commit/1a1820bbe3bf3b393105a342b414730f9ba105d3

Patch Set 1 #

Patch Set 2 : Regenerate html library #

Patch Set 3 : Remove the dart2js version. It's never called #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -19 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 1 3 chunks +3 lines, -10 lines 0 comments Download
M sdk/lib/html/html_common/conversions_dartium.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 3 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Alan Knight
TBR
5 years, 2 months ago (2015-10-14 20:43:34 UTC) #2
Alan Knight
Committed patchset #3 (id:40001) manually as 1a1820bbe3bf3b393105a342b414730f9ba105d3 (presubmit successful).
5 years, 2 months ago (2015-10-14 21:06:29 UTC) #3
terry
5 years, 2 months ago (2015-10-15 12:27:18 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698