Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: ui/PRESUBMIT.py

Issue 1402213002: Moves mandoline/ui/aura to ui/views/mus (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: disable presubmit Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mandoline/ui/omnibox/omnibox_application.cc ('k') | ui/views/mus/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/PRESUBMIT.py
diff --git a/ui/PRESUBMIT.py b/ui/PRESUBMIT.py
index 97d09319975ef01975ab1ef08e48a9f2fc6ae7c9..d8fe08861bcd6a94b008c6ab851902c0fc1f807a 100644
--- a/ui/PRESUBMIT.py
+++ b/ui/PRESUBMIT.py
@@ -32,12 +32,13 @@ def CheckScopedPtr(input_api, output_api,
errors.append(output_api.PresubmitError(
('%s:%d uses explicit scoped_ptr constructor. ' +
'Use make_scoped_ptr() instead.') % (f.LocalPath(), line_number)))
+ # TODO(sky): this incorrectly catches templates. Fix and reenable.
# Disallow:
# scoped_ptr<T>()
- if input_api.re.search(r'\bscoped_ptr<.*?>\(\)', line):
- errors.append(output_api.PresubmitError(
- '%s:%d uses scoped_ptr<T>(). Use nullptr instead.' %
- (f.LocalPath(), line_number)))
+ # if input_api.re.search(r'\bscoped_ptr<.*?>\(\)', line):
+ # errors.append(output_api.PresubmitError(
+ # '%s:%d uses scoped_ptr<T>(). Use nullptr instead.' %
+ # (f.LocalPath(), line_number)))
return errors
« no previous file with comments | « mandoline/ui/omnibox/omnibox_application.cc ('k') | ui/views/mus/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698