Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 1402213002: Moves mandoline/ui/aura to ui/views/mus (Closed)

Created:
5 years, 2 months ago by sky
Modified:
5 years, 2 months ago
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, tfarina, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves mandoline/ui/aura to ui/views/mus I renamed a couple of classes as well (mojo->mus). BUG=none TEST=none R=ben@chromium.org Committed: https://crrev.com/78bcb12f4603d637a4e1804795b74d31fb3780fe Cr-Commit-Position: refs/heads/master@{#354110}

Patch Set 1 #

Patch Set 2 : disable presubmit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -1276 lines) Patch
M components/mus/example/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/example/common/mus_views_init.h View 2 chunks +5 lines, -5 lines 0 comments Download
M components/mus/example/common/mus_views_init.cc View 3 chunks +5 lines, -5 lines 0 comments Download
D mandoline/ui/aura/BUILD.gn View 1 chunk +0 lines, -64 lines 0 comments Download
D mandoline/ui/aura/DEPS View 1 chunk +0 lines, -23 lines 0 comments Download
D mandoline/ui/aura/aura_init.h View 1 chunk +0 lines, -53 lines 0 comments Download
D mandoline/ui/aura/aura_init.cc View 1 chunk +0 lines, -91 lines 0 comments Download
D mandoline/ui/aura/input_method_mandoline.h View 1 chunk +0 lines, -50 lines 0 comments Download
D mandoline/ui/aura/input_method_mandoline.cc View 1 chunk +0 lines, -112 lines 0 comments Download
D mandoline/ui/aura/native_widget_view_manager.h View 1 chunk +0 lines, -70 lines 0 comments Download
D mandoline/ui/aura/native_widget_view_manager.cc View 1 chunk +0 lines, -133 lines 0 comments Download
D mandoline/ui/aura/surface_binding.h View 1 chunk +0 lines, -51 lines 0 comments Download
D mandoline/ui/aura/surface_binding.cc View 1 chunk +0 lines, -144 lines 0 comments Download
D mandoline/ui/aura/surface_context_factory.h View 1 chunk +0 lines, -57 lines 0 comments Download
D mandoline/ui/aura/surface_context_factory.cc View 1 chunk +0 lines, -98 lines 0 comments Download
D mandoline/ui/aura/window_tree_host_mojo.h View 1 chunk +0 lines, -74 lines 0 comments Download
D mandoline/ui/aura/window_tree_host_mojo.cc View 1 chunk +0 lines, -114 lines 0 comments Download
M mandoline/ui/desktop_ui/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M mandoline/ui/desktop_ui/browser_window.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mandoline/ui/desktop_ui/browser_window.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M mandoline/ui/omnibox/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M mandoline/ui/omnibox/omnibox_application.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M ui/PRESUBMIT.py View 1 1 chunk +5 lines, -4 lines 0 comments Download
A + ui/views/mus/BUILD.gn View 1 chunk +5 lines, -6 lines 0 comments Download
A + ui/views/mus/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
A + ui/views/mus/aura_init.h View 3 chunks +5 lines, -6 lines 0 comments Download
A + ui/views/mus/aura_init.cc View 4 chunks +4 lines, -4 lines 0 comments Download
A + ui/views/mus/input_method_mus.h View 2 chunks +9 lines, -10 lines 0 comments Download
A + ui/views/mus/input_method_mus.cc View 3 chunks +20 lines, -28 lines 0 comments Download
A + ui/views/mus/native_widget_view_manager.h View 4 chunks +13 lines, -13 lines 0 comments Download
A + ui/views/mus/native_widget_view_manager.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + ui/views/mus/surface_binding.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + ui/views/mus/surface_binding.cc View 3 chunks +5 lines, -6 lines 0 comments Download
A + ui/views/mus/surface_context_factory.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + ui/views/mus/surface_context_factory.cc View 4 chunks +4 lines, -6 lines 0 comments Download
A + ui/views/mus/window_tree_host_mus.h View 3 chunks +11 lines, -11 lines 0 comments Download
A + ui/views/mus/window_tree_host_mus.cc View 5 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
sky
5 years, 2 months ago (2015-10-14 20:06:06 UTC) #1
Ben Goodger (Google)
lgtm
5 years, 2 months ago (2015-10-14 20:06:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402213002/1
5 years, 2 months ago (2015-10-14 20:08:30 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/109425)
5 years, 2 months ago (2015-10-14 20:19:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402213002/20001
5 years, 2 months ago (2015-10-14 20:26:08 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-14 21:03:59 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 21:04:55 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/78bcb12f4603d637a4e1804795b74d31fb3780fe
Cr-Commit-Position: refs/heads/master@{#354110}

Powered by Google App Engine
This is Rietveld 408576698