FINALizing of the Node hierarchy.

Source/core/dom/Element.h

Index: Source/core/dom/Element.h
diff --git a/Source/core/dom/Element.h b/Source/core/dom/Element.h
index e2a2b1b8f7d994aab87cef43d1404dde06cea2c5..d48350442e8f74926ee6cf6c108af8847f9bb6cc 100644
--- a/Source/core/dom/Element.h
+++ b/Source/core/dom/Element.h
@@ -359,7 +359,7 @@ public:
     const AtomicString& prefix() const { return m_tagName.prefix(); }
     const AtomicString& namespaceURI() const { return m_tagName.namespaceURI(); }
 
-    virtual KURL baseURI() const;
+    virtual KURL baseURI() const OVERRIDE FINAL;
 
     virtual String nodeName() const;
 
@@ -417,7 +417,6 @@ public:
     ShadowRoot* shadowRoot() const;
 
     bool hasAuthorShadowRoot() const { return shadowRoot(); }
-    virtual void willAddAuthorShadowRoot() { }

[eseidel, 2013/04/29 20:57:21]

Why is this OK to remove?

[esprehn, 2013/04/29 22:02:55]

Nothing seems to call this now. Weird, I wonder when it was removed and why this
was left behind.

 
     ShadowRoot* userAgentShadowRoot() const;
     ShadowRoot* ensureUserAgentShadowRoot();
@@ -494,7 +493,7 @@ public:
 
     bool isFinishedParsingChildren() const { return isParsingChildrenFinished(); }
     virtual void finishParsingChildren();
-    virtual void beginParsingChildren();
+    virtual void beginParsingChildren() OVERRIDE FINAL;
 
     bool hasPseudoElements() const;
     PseudoElement* pseudoElement(PseudoId) const;
@@ -574,9 +573,9 @@ public:
     };
     
     void webkitRequestFullScreen(unsigned short flags);
-    virtual bool containsFullScreenElement() const;
-    virtual void setContainsFullScreenElement(bool);
-    virtual void setContainsFullScreenElementOnAncestorsCrossingFrameBoundaries(bool);
+    bool containsFullScreenElement() const;

[eseidel, 2013/04/29 20:57:21]

I would rather you separated changes like this out into a separate patch.  Why
are these OK to devirtualize?

[esprehn, 2013/04/29 22:02:55]

Ditto. It's clear that these don't need to be virtual now, but it seems really
unrelated to this patch.

+    void setContainsFullScreenElement(bool);
+    void setContainsFullScreenElementOnAncestorsCrossingFrameBoundaries(bool);
 
     // W3C API
     void webkitRequestFullscreen();
@@ -586,7 +585,7 @@ public:
 
     void webkitRequestPointerLock();
 
-    virtual bool isSpellCheckingEnabled() const;
+    bool isSpellCheckingEnabled() const;

[eseidel, 2013/04/29 20:57:21]

Same question.  It's not that I don't believe you, it's just easy to trip up
with changes like these and it's hard to tell they're correct while reading this
patch which is nominally about adding the FINAL keyword to places. :)

 
     PassRefPtr<RenderStyle> styleForRenderer();
 
@@ -615,8 +614,8 @@ protected:
 
     virtual InsertionNotificationRequest insertedInto(ContainerNode*) OVERRIDE;
     virtual void removedFrom(ContainerNode*) OVERRIDE;
-    virtual void childrenChanged(bool changedByParser = false, Node* beforeChange = 0, Node* afterChange = 0, int childCountDelta = 0);
-    virtual void removeAllEventListeners() OVERRIDE;
+    virtual void childrenChanged(bool changedByParser = false, Node* beforeChange = 0, Node* afterChange = 0, int childCountDelta = 0) OVERRIDE;
+    virtual void removeAllEventListeners() OVERRIDE FINAL;
 
     virtual bool willRecalcStyle(StyleChange);
     virtual void didRecalcStyle(StyleChange);
@@ -667,9 +666,9 @@ private:
 
     void scrollByUnits(int units, ScrollGranularity);
 
-    virtual void setPrefix(const AtomicString&, ExceptionCode&);
-    virtual NodeType nodeType() const;
-    virtual bool childTypeAllowed(NodeType) const;
+    virtual void setPrefix(const AtomicString&, ExceptionCode&) OVERRIDE FINAL;
+    virtual NodeType nodeType() const OVERRIDE FINAL;
+    virtual bool childTypeAllowed(NodeType) const OVERRIDE FINAL;
 
     void setAttributeInternal(size_t index, const QualifiedName&, const AtomicString& value, SynchronizationOfLazyAttribute);
     void addAttributeInternal(const QualifiedName&, const AtomicString& value, SynchronizationOfLazyAttribute);
@@ -684,9 +683,9 @@ private:
 
     void cancelFocusAppearanceUpdate();
 
-    virtual const AtomicString& virtualPrefix() const { return prefix(); }
-    virtual const AtomicString& virtualLocalName() const { return localName(); }
-    virtual const AtomicString& virtualNamespaceURI() const { return namespaceURI(); }
+    virtual const AtomicString& virtualPrefix() const OVERRIDE FINAL { return prefix(); }
+    virtual const AtomicString& virtualLocalName() const OVERRIDE FINAL { return localName(); }
+    virtual const AtomicString& virtualNamespaceURI() const OVERRIDE FINAL { return namespaceURI(); }
     virtual RenderStyle* virtualComputedStyle(PseudoId pseudoElementSpecifier = NOPSEUDO) { return computedStyle(pseudoElementSpecifier); }
     
     // cloneNode is private so that non-virtual cloneElementWithChildren and cloneElementWithoutChildren