Code quality and standards in SimpleBackend.

net/disk_cache/simple/simple_backend_impl.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_DISK_CACHE_SIMPLE_SIMPLE_BACKEND_IMPL_H_
 #define NET_DISK_CACHE_SIMPLE_SIMPLE_BACKEND_IMPL_H_
 
 #include <string>
 #include <utility>
 #include <vector>
 
 #include "base/compiler_specific.h"
 #include "base/files/file_path.h"
 #include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
 #include "base/task_runner.h"
 #include "net/base/cache_type.h"
 #include "net/disk_cache/disk_cache.h"
-#include "net/disk_cache/simple/simple_index.h"
 
 namespace base {
 class MessageLoopProxy;
 }
 
 namespace disk_cache {
 
 // SimpleBackendImpl is a new cache backend that stores entries in individual
 // files.
 
 // It is currently a work in progress, missing many features of a real cache,
 // such as eviction.
 
 // See http://www.chromium.org/developers/design-documents/network-stack/disk-cache/very-simple-backend
 
+class SimpleIndex;
+
 class NET_EXPORT_PRIVATE SimpleBackendImpl : public Backend {
  public:
   SimpleBackendImpl(const base::FilePath& path, int max_bytes,
                     net::CacheType type,
-                    const scoped_refptr<base::TaskRunner>& cache_thread,
+                    base::TaskRunner* cache_thread,

[Philippe, 2013/04/18 09:30:10]

What kind of guarantees do you need from this TaskRunner (and others)? I suspect
that you actually need a SingleThreadTaskRunner. For example, TaskRunner does
not guarantee the order in which posted tasks are run. It's a very high level
abstraction. In practice it will work as expected since you will provide an
instance of the correct implementation but I would suggest better expressing
your expectations here with a SingleThreadTaskRunner.

This would significantly increase the diff though :/

[gavinp, 2013/04/18 09:46:18]

Done.

                     net::NetLog* net_log);
 
   virtual ~SimpleBackendImpl();
 
   // Must run on IO Thread.
   int Init(const CompletionCallback& completion_callback);
 
   // From Backend:
   virtual net::CacheType GetCacheType() const OVERRIDE;
   virtual int32 GetEntryCount() const OVERRIDE;
@@ skipping 23 matching lines @@
   void InitializeIndex(const CompletionCallback& callback, int result);
 
   // Try to create the directory if it doesn't exist.
   // Must run on Cache Thread.
   static void CreateDirectory(
       base::MessageLoopProxy* io_thread,
       const base::FilePath& path,
       const InitializeIndexCallback& initialize_index_callback);
 
   const base::FilePath path_;
-  scoped_refptr<SimpleIndex> index_;
+  scoped_ptr<SimpleIndex> index_;
   const scoped_refptr<base::TaskRunner> cache_thread_;
 };
 
 }  // namespace disk_cache
 
 #endif  // NET_DISK_CACHE_SIMPLE_SIMPLE_BACKEND_IMPL_H_