Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Issue 1402153004: Revert of [Interpreter] Support for operator new. (Closed)

Created:
5 years, 2 months ago by Michael Achenbach
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Interpreter] Support for operator new. (patchset #17 id:290001 of https://codereview.chromium.org/1402943002/ ) Reason for revert: [Sheriff] Breaks arm64 debug: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20debug/builds/4595 Original issue's description: > [Interpreter] Support for operator new. > > This change add a new bytecode for operator new and implements it using > the Construct() builtin. > > BUG=v8:4280 > LOG=N > > Committed: https://crrev.com/8e4f9963d53913eab7fbd2f61a5733d8dc2169e7 > Cr-Commit-Position: refs/heads/master@{#31293} TBR=rmcilroy@chromium.org,bmeurer@chromium.org,oth@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280 Committed: https://crrev.com/0937cdbfbd62656ba2d4c8779e61bbad934198a6 Cr-Commit-Position: refs/heads/master@{#31298}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -628 lines) Patch
M src/arm/builtins-arm.cc View 2 chunks +9 lines, -35 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 2 chunks +0 lines, -32 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/builtins.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/code-factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/code-factory.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/compiler/interpreter-assembler.h View 1 chunk +2 lines, -11 lines 0 comments Download
M src/compiler/interpreter-assembler.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 4 chunks +10 lines, -61 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +0 lines, -9 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 chunk +1 line, -7 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/interpreter/bytecode-generator.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 4 chunks +18 lines, -49 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M src/mips/builtins-mips.cc View 2 chunks +0 lines, -29 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 2 chunks +0 lines, -29 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 2 chunks +0 lines, -27 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/x64/builtins-x64.cc View 2 chunks +8 lines, -53 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 2 chunks +3 lines, -69 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 chunk +0 lines, -59 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of [Interpreter] Support for operator new.
5 years, 2 months ago (2015-10-15 12:49:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402153004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402153004/1
5 years, 2 months ago (2015-10-15 12:49:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-15 12:50:00 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 12:50:21 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0937cdbfbd62656ba2d4c8779e61bbad934198a6
Cr-Commit-Position: refs/heads/master@{#31298}

Powered by Google App Engine
This is Rietveld 408576698