Preserve running CSS Animations across changes to animation styles according to same name index

Preserve running CSS Animations across changes to animation styles according to same name index

We currently only keep track of the last animation that used
a given @keyframes name. If multiple animations use the same
@keyframes rule we fail to update their timing input correctly
as animation styles are updated.
This change makes us track animation-name references to running
animations based on name and name index (nth occurrence of name)
rather than just name.

This behaviour does not conform to any spec text as the
specification does not dictate what to do in this scenario:
"Need to specify better handling of dynamic changes of animation-name"
https://drafts.csswg.org/css-animations-1/#other-open-issues

The behaviour introduced in this patch is arbitrary though
better than the existing behaviour of ignoring running
animations and crashing debug on timing updates.

BUG=487092
Committed: https://crrev.com/1737f9e86e74990aad0e9693ebf247c8ffbb86f9
Cr-Commit-Position: refs/heads/master@{#354457}

[alancutter (OOO until 2018), 2015-10-16 00:44:15]

alancutter@chromium.org changed reviewers:
+ dstockwell@chromium.org

[alancutter (OOO until 2018), 2015-10-16 00:48:43]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-16 00:49:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1402143004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1402143004/20001

[commit-bot: I haz the power, 2015-10-16 01:51:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-16 01:51:15]

Dry run: This issue passed the CQ dry run.

[dstockwell, 2015-10-16 01:51:37]

https://codereview.chromium.org/1402143004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp (right):

https://codereview.chromium.org/1402143004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp:293: nameIndex +=
(nameList[--j] == name);
This code is a bit...smelly.

for (...)
  if (...)
    nameIndex++;

Also, can't we just iterate forwards from 0 until we reach i?

[alancutter (OOO until 2018), 2015-10-16 01:56:19]

https://codereview.chromium.org/1402143004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp (right):

https://codereview.chromium.org/1402143004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp:293: nameIndex +=
(nameList[--j] == name);
On 2015/10/16 at 01:51:37, dstockwell wrote:
> This code is a bit...smelly.
> 
> for (...)
>   if (...)
>     nameIndex++;
> 
> Also, can't we just iterate forwards from 0 until we reach i?

Much better, done.

[dstockwell, 2015-10-16 02:26:43]

lgtm

[alancutter (OOO until 2018), 2015-10-16 02:34:34]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2015-10-16 02:34:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1402143004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1402143004/40001

[commit-bot: I haz the power, 2015-10-16 02:43:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-16 02:43:34]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[alancutter (OOO until 2018), 2015-10-16 04:04:32]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2015-10-16 04:04:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
dstockwell@chromium.org
Link to the patchset: https://codereview.chromium.org/1402143004/#ps60001
(title: "Semilcelon")

[commit-bot: I haz the power, 2015-10-16 04:04:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1402143004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1402143004/60001

[commit-bot: I haz the power, 2015-10-16 05:58:35]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-10-16 05:59:34]

Patchset 4 (id:??) landed as
https://crrev.com/1737f9e86e74990aad0e9693ebf247c8ffbb86f9
Cr-Commit-Position: refs/heads/master@{#354457}