Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1402123004: VM: Speed up PC descriptor verification code used in DEBUG mode. (Closed)

Created:
5 years, 2 months ago by Florian Schneider
Modified:
5 years, 2 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Speed up PC descriptor verification code used in DEBUG mode. Use O(n) verification code instead of O(n*n). BUG=https://github.com/dart-lang/sdk/issues/24596 R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/99a02ee652b5406c361847afa7e0dc3e0ac319f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -14 lines) Patch
M runtime/vm/object.cc View 2 chunks +18 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Florian Schneider
5 years, 2 months ago (2015-10-15 13:07:40 UTC) #2
srdjan
lgtm
5 years, 2 months ago (2015-10-15 16:55:00 UTC) #3
Florian Schneider
5 years, 2 months ago (2015-10-15 17:01:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
99a02ee652b5406c361847afa7e0dc3e0ac319f2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698