Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issue 1402103002: Revert of Revert "Post loading tasks on the appropriate WebFrameScheduler's queue." (Closed)

Created:
5 years, 2 months ago by Marc Treib
Modified:
5 years, 2 months ago
CC:
chromium-reviews, blink-reviews-platform-graphics_chromium.org, dshwang, eae+blinkwatch, kinuko+watch, rwlbuis, Yoav Weiss, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-html_chromium.org, jam, Justin Novosad, danakj, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, darin-cc_chromium.org, gavinp+loader_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-api_chromium.org, mlamouri+watch-content_chromium.org, sof, jbroman, feature-media-reviews_chromium.org, krit, Nate Chapin, tyoshino+watch_chromium.org, f(malita), mkwst+moarreviews-renderer_chromium.org, Stephen Chennney, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert "Post loading tasks on the appropriate WebFrameScheduler's queue." (patchset #2 id:20001 of https://codereview.chromium.org/1402933002/ ) Reason for revert: The failures happened again after reverting the original CL, so relanding that. Original issue's description: > Revert "Post loading tasks on the appropriate WebFrameScheduler's queue." > and "Fix a UAF in the BackgroundHtmlParser's constructor" > > This reverts commit https://crrev.com/f3080498facd16066076e7d459ba7cfda11e582c and https://crrev.com/76d7303845116b1c08bd327c46c99e264b626ada. > (CLs: https://codereview.chromium.org/1366883002 and https://codereview.chromium.org/1391013004.) > > Reason: Seems to have broken lots of browser_tests on WinXP. > > TBR=jochen@chromium.org > > BUG=510398, 538660, 541177 > > Committed: https://crrev.com/57587e3c7053dc33118ba5a2603879fc6010f6de > Cr-Commit-Position: refs/heads/master@{#353983} TBR=alexclarke@chromium.org,jochen@chromium.org,skyostil@chromium.org,sandersd@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=510398, 538660, 541177 Committed: https://crrev.com/87d364f6ed284ae24a2c7ff7de41250e3a23f244 Cr-Commit-Position: refs/heads/master@{#354006}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+345 lines, -91 lines) Patch
M components/html_viewer/web_url_loader_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/html_viewer/web_url_loader_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M components/scheduler/child/web_task_runner_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/scheduler/child/web_task_runner_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/child/blink_platform_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/child/blink_platform_impl.cc View 3 chunks +3 lines, -11 lines 0 comments Download
M content/child/request_info.h View 2 chunks +8 lines, -0 lines 0 comments Download
M content/child/request_info.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/child/resource_dispatcher.h View 3 chunks +5 lines, -0 lines 0 comments Download
M content/child/resource_dispatcher.cc View 4 chunks +16 lines, -0 lines 0 comments Download
M content/child/resource_scheduling_filter.h View 2 chunks +23 lines, -2 lines 0 comments Download
M content/child/resource_scheduling_filter.cc View 2 chunks +56 lines, -3 lines 0 comments Download
M content/child/web_url_loader_impl.h View 2 chunks +5 lines, -3 lines 0 comments Download
M content/child/web_url_loader_impl.cc View 13 chunks +45 lines, -10 lines 0 comments Download
M content/child/web_url_loader_impl_unittest.cc View 2 chunks +5 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 4 chunks +16 lines, -0 lines 0 comments Download
M content/test/mock_weburlloader.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/weburl_loader_mock.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/weburl_loader_mock.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M media/blink/mock_weburlloader.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.h View 5 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp View 11 chunks +14 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp View 12 chunks +13 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp View 2 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/FetchContext.h View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceLoader.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.h View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 4 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.h View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/TimerTest.cpp View 2 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/AssociatedURLLoader.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/AssociatedURLLoader.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebTaskRunner.h View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebURLLoader.h View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Marc Treib
Created Revert of Revert "Post loading tasks on the appropriate WebFrameScheduler's queue."
5 years, 2 months ago (2015-10-14 12:39:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402103002/1
5 years, 2 months ago (2015-10-14 12:40:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-14 12:42:02 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 12:43:03 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87d364f6ed284ae24a2c7ff7de41250e3a23f244
Cr-Commit-Position: refs/heads/master@{#354006}

Powered by Google App Engine
This is Rietveld 408576698