runtime/vm/flow_graph_type_propagator.cc - Issue 14021016: Track side-effect free paths in the graph to allow CSE and LICM for instructions that depend on som…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_type_propagator.cc

Issue 14021016: Track side-effect free paths in the graph to allow CSE and LICM for instructions that depend on som… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_type_propagator.cc

diff --git a/runtime/vm/flow_graph_type_propagator.cc b/runtime/vm/flow_graph_type_propagator.cc

index f3f77f8a82fc84465ae6fa7981def4778e4899cd..a96137a39eb0ac05ec36ef2fc2f83720562ac4bf 100644

--- a/runtime/vm/flow_graph_type_propagator.cc

+++ b/runtime/vm/flow_graph_type_propagator.cc

@@ -256,7 +256,7 @@ void FlowGraphTypePropagator::VisitCheckSmi(CheckSmiInstr* check) {

void FlowGraphTypePropagator::VisitCheckClass(CheckClassInstr* check) {

if ((check->unary_checks().NumberOfChecks() != 1) ||

- check->AffectedBySideEffect()) {

+ !check->Dependencies().IsNone()) {

// TODO(vegorov): If check is affected by side-effect we can still propagate

// the type further but not the cid.

return;

« runtime/vm/flow_graph_optimizer.cc ('K') | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/hash_map.h » ('j') | runtime/vm/intermediate_language.h » ('J')