Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1402093002: [Interpreter]: Add fake support for try/catch/finally. (Closed)

Created:
5 years, 2 months ago by rmcilroy
Modified:
5 years, 2 months ago
Reviewers:
oth
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter]: Add fake support for try/catch/finally. Adds fake try/catch/finally support hidden behind the flag --ignition-fake-try-catch. BUG=v8:4280 LOG=N Committed: https://crrev.com/370984018f32aaf04acf65119182f779e91e349c Cr-Commit-Position: refs/heads/master@{#31288}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -1 line) Patch
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 2 chunks +74 lines, -0 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 2 chunks +29 lines, -0 lines 0 comments Download
M test/test262/testcfg.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
rmcilroy
Orion: please take a look, thanks.
5 years, 2 months ago (2015-10-14 10:07:44 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402093002/1
5 years, 2 months ago (2015-10-14 11:28:56 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-14 12:20:03 UTC) #6
oth
lgtm
5 years, 2 months ago (2015-10-15 09:14:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402093002/1
5 years, 2 months ago (2015-10-15 10:33:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-15 10:35:24 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 10:35:37 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/370984018f32aaf04acf65119182f779e91e349c
Cr-Commit-Position: refs/heads/master@{#31288}

Powered by Google App Engine
This is Rietveld 408576698