Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 140203002: MIPS: Fix Win32 buildbreak (caused by overriden methods that have disappeared while having the patc… (Closed)

Created:
6 years, 11 months ago by palfia
Modified:
6 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Fix Win32 buildbreak (caused by overriden methods that have disappeared while having the patch out for code review). Port r18627 (c2ba7b25) BUG= R=plind44@gmail.com Committed: https://code.google.com/p/v8/source/detail?r=18631

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M src/mips/lithium-mips.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
palfia
PTAL. This depends on: https://codereview.chromium.org/137663005
6 years, 11 months ago (2014-01-15 22:50:30 UTC) #1
Paul Lind
LGTM.
6 years, 11 months ago (2014-01-15 23:32:48 UTC) #2
palfia
6 years, 11 months ago (2014-01-16 00:06:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18631 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698