Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1402023002: Remove most of WebDOMEvent and delete WebDOMMouseEvent. (Closed)

Created:
5 years, 2 months ago by esprehn
Modified:
5 years, 2 months ago
Reviewers:
pdr., dglazkov
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove most of WebDOMEvent and delete WebDOMMouseEvent. While content needs to create a few event types, it almost never needs to read any data back off them. All of these getters are actually dead code. I also noticed that WebDOMMouseEvent is dead and removed it. Committed: https://crrev.com/3ade2f22f2a1a3118c5bef2daa9df79f10bab530 Cr-Commit-Position: refs/heads/master@{#353900}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -321 lines) Patch
M third_party/WebKit/Source/web/WebDOMEvent.cpp View 2 chunks +0 lines, -128 lines 0 comments Download
D third_party/WebKit/Source/web/WebDOMMouseEvent.cpp View 1 chunk +0 lines, -98 lines 0 comments Download
M third_party/WebKit/Source/web/WebDOMProgressEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/web.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/web/WebDOMEvent.h View 3 chunks +0 lines, -36 lines 0 comments Download
D third_party/WebKit/public/web/WebDOMMouseEvent.h View 1 chunk +0 lines, -56 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
esprehn
5 years, 2 months ago (2015-10-13 21:47:02 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402023002/1
5 years, 2 months ago (2015-10-13 21:55:18 UTC) #4
pdr.
lgtm
5 years, 2 months ago (2015-10-13 22:04:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402023002/1
5 years, 2 months ago (2015-10-13 22:08:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-13 23:21:30 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 23:22:21 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ade2f22f2a1a3118c5bef2daa9df79f10bab530
Cr-Commit-Position: refs/heads/master@{#353900}

Powered by Google App Engine
This is Rietveld 408576698