Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Issue 14020004: Remove the remains of unused guards. (Closed)

Created:
7 years, 7 months ago by lgombos
Modified:
7 years, 7 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove the remains of unused guards. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150174

Patch Set 1 #

Total comments: 1

Patch Set 2 : More coverage for fast/events/event-creation. #

Patch Set 3 : eep DeviceOrientation and DeviceMotion tests disabled as #

Patch Set 4 : Keep DeviceOrientation and DeviceMotion tests disabled as they are disabled runtime. #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -19 lines) Patch
M LayoutTests/fast/dom/Window/window-properties-device-orientation.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/window-properties-device-orientation-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/event-creation.html View 1 2 3 4 1 chunk +6 lines, -11 lines 0 comments Download
M LayoutTests/fast/events/event-creation-expected.txt View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/touch/script-tests/tap-highlight-color.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/touch/tap-highlight-color.html View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/features.gypi View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
lgombos
These guards have been removed recently, but they are still in the code in a ...
7 years, 7 months ago (2013-04-28 15:25:45 UTC) #1
abarth-chromium
lgtm https://codereview.chromium.org/14020004/diff/1/LayoutTests/fast/events/event-creation.html File LayoutTests/fast/events/event-creation.html (left): https://codereview.chromium.org/14020004/diff/1/LayoutTests/fast/events/event-creation.html#oldcode211 LayoutTests/fast/events/event-creation.html:211: // shouldBeTrue("document.createEvent('TouchEvent').constructor === window.TouchEvent"); Can we uncomment these ...
7 years, 7 months ago (2013-04-28 16:20:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14020004/19001
7 years, 7 months ago (2013-05-11 21:58:34 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-11 23:15:03 UTC) #4
Message was sent while issue was closed.
Change committed as 150174

Powered by Google App Engine
This is Rietveld 408576698