Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 14020002: chromeos: Move chrome/browser/chromeos/extensions/file_browser* to chrome/browser/chromeos/file_man… (Closed)

Created:
7 years, 8 months ago by hashimoto
Modified:
7 years, 8 months ago
Reviewers:
Lei Zhang, kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

chromeos: Move chrome/browser/chromeos/extensions/file_browser* to chrome/browser/chromeos/file_manager/ Move file_browser* (except API related files) to file_manager and rename them to file_manager*. API related files will get moved in separate changes. BUG=224200 TEST=build Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193575

Patch Set 1 #

Patch Set 2 : Rename classes/files #

Total comments: 4

Patch Set 3 : rebase #

Patch Set 4 : Sort #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -3034 lines) Patch
M chrome/browser/chromeos/drive/drive_file_system.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/external_filesystem_apitest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/extensions/file_browser_event_router.h View 1 chunk +0 lines, -237 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_browser_event_router.cc View 1 chunk +0 lines, -1020 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_browser_event_router_browsertest.cc View 1 chunk +0 lines, -74 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_browser_handler.h View 1 chunk +0 lines, -102 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_browser_handler.cc View 1 chunk +0 lines, -293 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_browser_manifest_unittest.cc View 1 chunk +0 lines, -183 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_browser_notifications.h View 1 chunk +0 lines, -100 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_browser_notifications.cc View 1 chunk +0 lines, -394 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_browser_notifications_browsertest.cc View 1 chunk +0 lines, -179 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_browser_notifications_unittest.cc View 1 chunk +0 lines, -225 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_private_api.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_private_api.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/chromeos/extensions/file_manager/file_browser_handler.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/extensions/file_manager/file_browser_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_handler_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/extensions/file_manager/file_manager_event_router.h View 1 7 chunks +12 lines, -12 lines 0 comments Download
A + chrome/browser/chromeos/extensions/file_manager/file_manager_event_router.cc View 1 36 chunks +66 lines, -66 lines 0 comments Download
A + chrome/browser/chromeos/extensions/file_manager/file_manager_event_router_browsertest.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/chromeos/extensions/file_manager/file_manager_manifest_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/extensions/file_manager/file_manager_notifications.h View 1 4 chunks +8 lines, -8 lines 0 comments Download
A + chrome/browser/chromeos/extensions/file_manager/file_manager_notifications.cc View 1 17 chunks +34 lines, -34 lines 0 comments Download
A + chrome/browser/chromeos/extensions/file_manager/file_manager_notifications_browsertest.cc View 1 9 chunks +24 lines, -24 lines 0 comments Download
A + chrome/browser/chromeos/extensions/file_manager/file_manager_notifications_unittest.cc View 1 10 chunks +53 lines, -53 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hashimoto
thestig@: Please review chrome/chrome_browser_chromeos.gypi kinaba@: Please review other parts.
7 years, 8 months ago (2013-04-10 05:12:55 UTC) #1
hashimoto
New patch set with: - Undo rename of file_browser_handler.* because they are part of fileBrowserHandler ...
7 years, 8 months ago (2013-04-10 06:12:13 UTC) #2
kinaba
lgtm
7 years, 8 months ago (2013-04-10 06:32:49 UTC) #3
hashimoto
On 2013/04/10 06:32:49, kinaba wrote: > lgtm Lei, could you take a look at chrome/chrome_browser_chromeos.gypi ...
7 years, 8 months ago (2013-04-10 10:56:42 UTC) #4
Lei Zhang
lgtm https://codereview.chromium.org/14020002/diff/5001/chrome/chrome_browser_chromeos.gypi File chrome/chrome_browser_chromeos.gypi (right): https://codereview.chromium.org/14020002/diff/5001/chrome/chrome_browser_chromeos.gypi#newcode735 chrome/chrome_browser_chromeos.gypi:735: 'browser/chromeos/extensions/file_manager/file_browser_handler.cc', nit: alphabetical order https://codereview.chromium.org/14020002/diff/5001/chrome/chrome_tests.gypi File chrome/chrome_tests.gypi (right): ...
7 years, 8 months ago (2013-04-10 19:01:46 UTC) #5
hashimoto
https://codereview.chromium.org/14020002/diff/5001/chrome/chrome_browser_chromeos.gypi File chrome/chrome_browser_chromeos.gypi (right): https://codereview.chromium.org/14020002/diff/5001/chrome/chrome_browser_chromeos.gypi#newcode735 chrome/chrome_browser_chromeos.gypi:735: 'browser/chromeos/extensions/file_manager/file_browser_handler.cc', On 2013/04/10 19:01:46, Lei Zhang wrote: > nit: ...
7 years, 8 months ago (2013-04-11 02:43:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/14020002/21001
7 years, 8 months ago (2013-04-11 02:44:16 UTC) #7
commit-bot: I haz the power
7 years, 8 months ago (2013-04-11 04:40:18 UTC) #8
Message was sent while issue was closed.
Change committed as 193575

Powered by Google App Engine
This is Rietveld 408576698