Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1401933004: Switch tab.cc to use an empty border for the contents. (Closed)

Created:
5 years, 2 months ago by Peter Kasting
Modified:
5 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch tab.cc to use an empty border for the contents. This is a small code simplification. Also clean up border.cc a bit -- use gfx::Insets more consistently, make the class naming (SolidSidedBorder) match the function naming (CreateSolidSidedBorder()), and be consistent about whether or not to inline class methods. BUG=none TEST=none Committed: https://crrev.com/6322a36ae3aa51c4ec9537486c6c3bae5427c545 Cr-Commit-Position: refs/heads/master@{#353918}

Patch Set 1 #

Patch Set 2 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -65 lines) Patch
M chrome/browser/ui/views/tabs/tab.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_unittest.cc View 1 1 chunk +9 lines, -3 lines 0 comments Download
M ui/views/border.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/border.cc View 8 chunks +60 lines, -51 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Peter Kasting
5 years, 2 months ago (2015-10-13 21:37:22 UTC) #2
sky
LGTM
5 years, 2 months ago (2015-10-13 21:52:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1401933004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1401933004/1
5 years, 2 months ago (2015-10-13 21:55:17 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/115256) win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
5 years, 2 months ago (2015-10-13 22:43:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1401933004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1401933004/20001
5 years, 2 months ago (2015-10-13 23:20:34 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-14 00:09:40 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 00:10:31 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6322a36ae3aa51c4ec9537486c6c3bae5427c545
Cr-Commit-Position: refs/heads/master@{#353918}

Powered by Google App Engine
This is Rietveld 408576698