Loosen checking on the bytes following 'stream'

Loosen checking on the bytes following 'stream'

PDF specs say that end of line markers shall follow the
keyword "stream". But a white space before end of line
markers follows this keyword in the test pdf files.

BUG=543018
R=thestig@chromium.org, tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/b5cbfb4cd12b6499912367f9a1e11c666157acb8

[jun_fang, 2015-10-15 08:47:06]

jun_fang@foxitsoftware.com changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[jun_fang, 2015-10-15 08:49:54]

On 2015/10/15 08:47:06, jun_fang wrote:
> mailto:jun_fang@foxitsoftware.com changed reviewers:
> + mailto:thestig@chromium.org, mailto:tsepez@chromium.org

Hi Tom and Lei,

Please review this CL. It loosen the checking on 
bytes following the keyword "stream".

[Lei Zhang, 2015-10-15 09:54:01]

lgtm

https://codereview.chromium.org/1401923005/diff/1/testing/resources/pixel/bug...
File testing/resources/pixel/bug_543018_2.in (right):

https://codereview.chromium.org/1401923005/diff/1/testing/resources/pixel/bug...
testing/resources/pixel/bug_543018_2.in:40: %   The content in stream should be
renderred as text.
typo: "rendered"

[jun_fang, 2015-10-15 10:25:23]

On 2015/10/15 09:54:01, Lei Zhang wrote:
> lgtm
> 
>
https://codereview.chromium.org/1401923005/diff/1/testing/resources/pixel/bug...
> File testing/resources/pixel/bug_543018_2.in (right):
> 
>
https://codereview.chromium.org/1401923005/diff/1/testing/resources/pixel/bug...
> testing/resources/pixel/bug_543018_2.in:40: %   The content in stream should
be
> renderred as text.
> typo: "rendered"

Thanks! Can you help me check whether this patch can pass pixel tests on Mac?

[jun_fang, 2015-10-15 10:27:27]

https://codereview.chromium.org/1401923005/diff/1/testing/resources/pixel/bug...
File testing/resources/pixel/bug_543018_2.in (right):

https://codereview.chromium.org/1401923005/diff/1/testing/resources/pixel/bug...
testing/resources/pixel/bug_543018_2.in:40: %   The content in stream should be
renderred as text.
On 2015/10/15 09:54:01, Lei Zhang wrote:
> typo: "rendered"

Acknowledged.

[jun_fang, 2015-10-15 10:39:16]

On 2015/10/15 10:27:27, jun_fang wrote:
>
https://codereview.chromium.org/1401923005/diff/1/testing/resources/pixel/bug...
> File testing/resources/pixel/bug_543018_2.in (right):
> 
>
https://codereview.chromium.org/1401923005/diff/1/testing/resources/pixel/bug...
> testing/resources/pixel/bug_543018_2.in:40: %   The content in stream should
be
> renderred as text.
> On 2015/10/15 09:54:01, Lei Zhang wrote:
> > typo: "rendered"
> 
> Acknowledged.

Below was abstracted from PDF spec:

All streams shall be indirect objects (see 7.3.10, "Indirect Objects") and 
the stream dictionary shall be a direct object. The keyword stream that 
follows the stream dictionary shall be followed by an end-of-line marker
consisting of either a CARRIAGE RETURN and a LINE FEED or just a LINE FEED, 
and not by a CARRIAGE RETURN alone.

[Tom Sepez, 2015-10-15 16:11:13]

LGTM after tidying comments.  Thanks for the good tests!

https://codereview.chromium.org/1401923005/diff/20001/testing/resources/pixel...
File testing/resources/pixel/bug_543018_1.in (right):

https://codereview.chromium.org/1401923005/diff/20001/testing/resources/pixel...
testing/resources/pixel/bug_543018_1.in:38: %   A white space rather than end of
line makers follows the keyword "stream".
nit: markers

https://codereview.chromium.org/1401923005/diff/20001/testing/resources/pixel...
File testing/resources/pixel/bug_543018_2.in (right):

https://codereview.chromium.org/1401923005/diff/20001/testing/resources/pixel...
testing/resources/pixel/bug_543018_2.in:38: %   Couple white spaces and chars
follow the keyword "stream"
nit: s/Couple/Several/ as there are 3 white spaces, and couple usually means
two. [please don't hit me :) ].

[Lei Zhang, 2015-10-15 18:05:07]

On 2015/10/15 10:25:23, jun_fang wrote:
> On 2015/10/15 09:54:01, Lei Zhang wrote:
> > lgtm
> > 
> >
>
https://codereview.chromium.org/1401923005/diff/1/testing/resources/pixel/bug...
> > File testing/resources/pixel/bug_543018_2.in (right):
> > 
> >
>
https://codereview.chromium.org/1401923005/diff/1/testing/resources/pixel/bug...
> > testing/resources/pixel/bug_543018_2.in:40: %   The content in stream should
> be
> > renderred as text.
> > typo: "rendered"
> 
> Thanks! Can you help me check whether this patch can pass pixel tests on Mac?

It does not pass on Mac. Feel free to either add the Mac-specific PNGs, or just
commit and I'll fix it up afterwards in a different CL.

[Lei Zhang, 2015-10-15 18:09:02]

On 2015/10/15 10:39:16, jun_fang wrote:
> Below was abstracted from PDF spec:
> 
> All streams shall be indirect objects (see 7.3.10, "Indirect Objects") and 
> the stream dictionary shall be a direct object. The keyword stream that 
> follows the stream dictionary shall be followed by an end-of-line marker
> consisting of either a CARRIAGE RETURN and a LINE FEED or just a LINE FEED, 
> and not by a CARRIAGE RETURN alone.

So basically, the spec says it should be: stream(CRLF|LF), but other PDF viewers
tolerate the violation, so we should too.

[Lei Zhang, 2015-10-15 21:22:21]

On 2015/10/15 18:05:07, Lei Zhang wrote:
> On 2015/10/15 10:25:23, jun_fang wrote:
> > On 2015/10/15 09:54:01, Lei Zhang wrote:
> > > lgtm
> > > 
> > >
> >
>
https://codereview.chromium.org/1401923005/diff/1/testing/resources/pixel/bug...
> > > File testing/resources/pixel/bug_543018_2.in (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1401923005/diff/1/testing/resources/pixel/bug...
> > > testing/resources/pixel/bug_543018_2.in:40: %   The content in stream
should
> > be
> > > renderred as text.
> > > typo: "rendered"
> > 
> > Thanks! Can you help me check whether this patch can pass pixel tests on
Mac?
> 
> It does not pass on Mac. Feel free to either add the Mac-specific PNGs, or
just
> commit and I'll fix it up afterwards in a different CL.

You just need to copy bug_524043_5_expected_mac.pdf.0.png to
bug_543018_1_expected_mac.pdf.0.png and bug_543018_2_expected_mac.pdf.0.png.

[jun_fang, 2015-10-15 23:19:42]

On 2015/10/15 21:22:21, Lei Zhang wrote:
> On 2015/10/15 18:05:07, Lei Zhang wrote:
> > On 2015/10/15 10:25:23, jun_fang wrote:
> > > On 2015/10/15 09:54:01, Lei Zhang wrote:
> > > > lgtm
> > > > 
> > > >
> > >
> >
>
https://codereview.chromium.org/1401923005/diff/1/testing/resources/pixel/bug...
> > > > File testing/resources/pixel/bug_543018_2.in (right):
> > > > 
> > > >
> > >
> >
>
https://codereview.chromium.org/1401923005/diff/1/testing/resources/pixel/bug...
> > > > testing/resources/pixel/bug_543018_2.in:40: %   The content in stream
> should
> > > be
> > > > renderred as text.
> > > > typo: "rendered"
> > > 
> > > Thanks! Can you help me check whether this patch can pass pixel tests on
> Mac?
> > 
> > It does not pass on Mac. Feel free to either add the Mac-specific PNGs, or
> just
> > commit and I'll fix it up afterwards in a different CL.
> 
> You just need to copy bug_524043_5_expected_mac.pdf.0.png to
> bug_543018_1_expected_mac.pdf.0.png and bug_543018_2_expected_mac.pdf.0.png.

OK.

[jun_fang, 2015-10-16 02:41:45]

https://codereview.chromium.org/1401923005/diff/20001/testing/resources/pixel...
File testing/resources/pixel/bug_543018_1.in (right):

https://codereview.chromium.org/1401923005/diff/20001/testing/resources/pixel...
testing/resources/pixel/bug_543018_1.in:38: %   A white space rather than end of
line makers follows the keyword "stream".
On 2015/10/15 16:11:13, Tom Sepez wrote:
> nit: markers

Acknowledged.

https://codereview.chromium.org/1401923005/diff/20001/testing/resources/pixel...
File testing/resources/pixel/bug_543018_2.in (right):

https://codereview.chromium.org/1401923005/diff/20001/testing/resources/pixel...
testing/resources/pixel/bug_543018_2.in:38: %   Couple white spaces and chars
follow the keyword "stream"
On 2015/10/15 16:11:13, Tom Sepez wrote:
> nit: s/Couple/Several/ as there are 3 white spaces, and couple usually means
> two. [please don't hit me :) ].

Acknowledged.

[Lei Zhang, 2015-10-16 02:44:02]

Let's land this and see how it goes.

[jun_fang, 2015-10-16 02:45:30]

Committed patchset #3 (id:40001) manually as
b5cbfb4cd12b6499912367f9a1e11c666157acb8 (presubmit successful).