Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(73)

Issue 1401873004: Remove check for valid account info in ChildAccountService. (Closed)

Created:
2 years, 1 month ago by Bernhard Bauer
Modified:
2 years, 1 month ago
Reviewers:
knn
CC:
chromium-reviews, pam+watch_chromium.org, Marc Treib
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove check for valid account info in ChildAccountService. IsValid() is a bit too strict for our purposes here, as the AccountInfo is considered invalid if the UserInfo request failed, which would then disable child account detection. In addition, the flag we are interested in (is_child_account) is the only thing that AccountInfo::IsValid() does _not_ consider, so the return value really has nothing to do with what we want. BUG=543133 Committed: https://crrev.com/89fae285133c9ef8d113892a219e13e98af5100b Cr-Commit-Position: refs/heads/master@{#354786}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : chromeos #

Patch Set 4 : revert #

Patch Set 5 : review #

Messages

Total messages: 11 (3 generated)
Bernhard Bauer
Please review.
2 years, 1 month ago (2015-10-19 09:19:31 UTC) #2
knn
lgtm. I seem to have made IsChildAccountStatusKnown() fragile. Will investigate this later and fix that.
2 years, 1 month ago (2015-10-19 09:44:55 UTC) #3
knn
On an unrelated note. Can you also move up the IsChildAccountDetectionEnabled() check before everything else?
2 years, 1 month ago (2015-10-19 09:47:27 UTC) #4
Bernhard Bauer
On 2015/10/19 09:47:27, knn wrote: > On an unrelated note. Can you also move up ...
2 years, 1 month ago (2015-10-19 15:29:24 UTC) #5
Bernhard Bauer
+Marc FYI
2 years, 1 month ago (2015-10-19 15:29:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1401873004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1401873004/80001
2 years, 1 month ago (2015-10-19 15:30:21 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
2 years, 1 month ago (2015-10-19 16:35:59 UTC) #10
commit-bot: I haz the power
2 years, 1 month ago (2015-10-19 16:37:04 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/89fae285133c9ef8d113892a219e13e98af5100b
Cr-Commit-Position: refs/heads/master@{#354786}

Powered by Google App Engine
This is Rietveld efc10ee0f