Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 1401853005: Dart: Makes timing of sending trace events configurable. (Closed)

Created:
5 years, 2 months ago by zra
Modified:
5 years, 2 months ago
Reviewers:
Cutch
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Dart: Makes timing of sending trace events configurable. There was a change to send trace events only when tracing stops. This is appropriate for some situations but not others. This change adds an option to configure the timing of sending trace events. BUG= R=johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/4d9fcdb7903dad4e2e5537c6cea147c52f17aa11

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -92 lines) Patch
M examples/dart/traced_application/lib/main.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/common/dart/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/common/dart/lib/src/trace_provider_impl.dart View 4 chunks +39 lines, -13 lines 0 comments Download
D mojo/common/dart/lib/trace_provider_impl.dart View 1 chunk +0 lines, -72 lines 0 comments Download
M mojo/common/dart/lib/tracing_helper.dart View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
zra
5 years, 2 months ago (2015-10-14 17:23:53 UTC) #2
qsr
What is the issue with always getting the trace at the end? Thta's what the ...
5 years, 2 months ago (2015-10-14 17:31:09 UTC) #3
zra
On 2015/10/14 17:31:09, qsr wrote: > What is the issue with always getting the trace ...
5 years, 2 months ago (2015-10-14 17:39:04 UTC) #4
Cutch
lgtm
5 years, 2 months ago (2015-10-15 16:44:25 UTC) #5
zra
5 years, 2 months ago (2015-10-15 16:58:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4d9fcdb7903dad4e2e5537c6cea147c52f17aa11 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698