Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 1401853002: Fix debug crash when compositing keyword animations together (Closed)

Created:
5 years, 2 months ago by alancutter (OOO until 2018)
Modified:
5 years, 2 months ago
Reviewers:
dstockwell
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@_specialCase0and1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix debug crash when compositing keyword animations together This change makes CSSValueInterpolationType composite by replacement instead of crashing in debug. Committed: https://crrev.com/e450c785ae3f5937d93b3b305460193fccbcc30d Cr-Commit-Position: refs/heads/master@{#353940}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/animations/keyword-composition-crash.html View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSValueInterpolationType.h View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
alancutter (OOO until 2018)
5 years, 2 months ago (2015-10-13 06:52:11 UTC) #2
dstockwell
lgtm
5 years, 2 months ago (2015-10-13 06:54:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1401853002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1401853002/20001
5 years, 2 months ago (2015-10-14 00:11:16 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-14 02:14:00 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 02:15:36 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e450c785ae3f5937d93b3b305460193fccbcc30d
Cr-Commit-Position: refs/heads/master@{#353940}

Powered by Google App Engine
This is Rietveld 408576698