Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Issue 140183007: Windows: Bootstrap Python first and get rid of Python 2.6 legacy (Closed)

Created:
6 years, 10 months ago by anatoly techtonik
Modified:
6 years, 9 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Windows: Bootstrap Python first and get rid of Python 2.6 legacy If loaded first, Python can then be used to replace JS bootstrapping logic if appropriate libs are already present in depot_tools. BUG=328453 AUTHOR=techtonik@gmail.com R=iannucci@chromium.org, maruel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257248

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -73 lines) Patch
D bootstrap/win/python.new.bat View 1 chunk +0 lines, -8 lines 2 comments Download
M bootstrap/win/win_tools.bat View 4 chunks +38 lines, -65 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
iannucci
6 years, 10 months ago (2014-02-11 09:11:34 UTC) #1
iannucci
https://codereview.chromium.org/140183007/diff/1/bootstrap/win/python.new.bat File bootstrap/win/python.new.bat (left): https://codereview.chromium.org/140183007/diff/1/bootstrap/win/python.new.bat#oldcode7 bootstrap/win/python.new.bat:7: set PATH=%~dp0python_bin;%PATH% I don't think this should be deleted?
6 years, 10 months ago (2014-02-11 09:12:13 UTC) #2
anatoly techtonik
https://codereview.chromium.org/140183007/diff/1/bootstrap/win/python.new.bat File bootstrap/win/python.new.bat (left): https://codereview.chromium.org/140183007/diff/1/bootstrap/win/python.new.bat#oldcode7 bootstrap/win/python.new.bat:7: set PATH=%~dp0python_bin;%PATH% There is still python276.new.bat file which is ...
6 years, 10 months ago (2014-02-11 09:26:25 UTC) #3
anatoly techtonik
Any comments to push this further?
6 years, 10 months ago (2014-02-19 13:39:17 UTC) #4
iannucci
I'm OK with this, but I really don't feel comfortable giving a final el gee ...
6 years, 10 months ago (2014-02-19 18:46:30 UTC) #5
anatoly techtonik
Ping?
6 years, 9 months ago (2014-02-27 08:08:02 UTC) #6
anatoly techtonik
It is possible to remove python276.new.bat instead of python.new.bat Should I do this?
6 years, 9 months ago (2014-02-27 08:09:46 UTC) #7
M-A Ruel
Ok, lgtm. This will need an announcement on chromium-dev. The CQ can't be used because ...
6 years, 9 months ago (2014-02-27 13:33:37 UTC) #8
anatoly techtonik
Thanks for review. Any chance to get it committed this week?
6 years, 9 months ago (2014-03-05 10:03:47 UTC) #9
anatoly techtonik
Another week. No progress. Another ping.
6 years, 9 months ago (2014-03-13 04:00:06 UTC) #10
iannucci
Sorry for the lag. LGTM. I'll announce and land tomorrow.
6 years, 9 months ago (2014-03-13 08:19:39 UTC) #11
iannucci
(though it occurs to me that fetching via the svn https interface is pretty sketch. ...
6 years, 9 months ago (2014-03-13 08:23:14 UTC) #12
anatoly techtonik
Sounds good. Waiting for tomorrow announcement. =)
6 years, 9 months ago (2014-03-13 11:01:41 UTC) #13
iannucci
Committed patchset #1 manually as r257248.
6 years, 9 months ago (2014-03-14 23:52:35 UTC) #14
anatoly techtonik
You've removed wrong file in https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/c64d3765a03aa66d980f66109f58eb3b05a4cb18%5E%21/#F1 The removed one should be python.new.bat, not pylint.new.bat
6 years, 9 months ago (2014-03-17 20:18:45 UTC) #15
anatoly techtonik
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/c64d37
6 years, 9 months ago (2014-03-17 20:20:26 UTC) #16
iannucci
On 2014/03/17 20:20:26, anatoly techtonik wrote: > https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/c64d37 Aww, fail :(. I'll fix it. >_<
6 years, 9 months ago (2014-03-17 20:24:38 UTC) #17
anatoly techtonik
Well, not necessary a fail. I've noticed this by reading code, so there are chances ...
6 years, 9 months ago (2014-03-17 20:30:37 UTC) #18
iannucci
6 years, 9 months ago (2014-03-17 20:31:28 UTC) #19
Message was sent while issue was closed.
On 2014/03/17 20:24:38, iannucci wrote:
> On 2014/03/17 20:20:26, anatoly techtonik wrote:
> > https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/c64d37
> 
> Aww, fail :(.
> 
> I'll fix it. >_<

CL to fix is here: https://chromiumcodereview.appspot.com/196343024/

Powered by Google App Engine
This is Rietveld 408576698