Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 140183005: Unify function name validation in Parser and PreParser. (Closed)

Created:
6 years, 10 months ago by marja
Modified:
6 years, 10 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Unify function name validation in Parser and PreParser. BUG=3126 LOG=N R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19193

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -45 lines) Patch
M src/parser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/parser.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M src/preparser.h View 1 chunk +8 lines, -1 line 0 comments Download
M src/preparser.cc View 6 chunks +62 lines, -35 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ulan
lgtm
6 years, 10 months ago (2014-02-07 10:46:35 UTC) #1
marja
6 years, 10 months ago (2014-02-07 10:47:08 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r19193 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698