third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp - Issue 1401813002: Cache User Agent string in BlinkPlatformImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

Issue 1401813002: Cache User Agent string in BlinkPlatformImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: moved to FrameLoaderClientImpl Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp b/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

index 4a6c43417c0624b63a46876258a7f5c6227dedba..e85967fb4d1be223e0c43c880f67fab34b6472ae 100644

--- a/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

+++ b/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

@@ -686,7 +686,9 @@ String FrameLoaderClientImpl::userAgent()

if (!override.isEmpty())

return override;

- return Platform::current()->userAgent();

+ if (m_userAgent.isNull())

+ m_userAgent = Platform::current()->userAgent();

kinuko 2015/10/16 11:12:21 Maybe add a comment in Platform.h to note that the

tzik 2015/10/19 08:16:48 Done.

+ return m_userAgent;

}

String FrameLoaderClientImpl::doNotTrackValue()