[Android] Refactor NativeView to be able to use it for AutofillDialog.

content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser;
 
 import android.app.Activity;
 import android.content.Context;
 import android.content.pm.ActivityInfo;
 import android.content.pm.PackageManager;
@@ skipping 27 matching lines @@
 import com.google.common.annotations.VisibleForTesting;
 
 import org.chromium.base.CalledByNative;
 import org.chromium.base.JNINamespace;
 import org.chromium.base.WeakContext;
 import org.chromium.content.R;
 import org.chromium.content.browser.ContentViewGestureHandler.MotionEventDelegate;
 import org.chromium.content.browser.ImeAdapter.AdapterInputConnectionFactory;
 import org.chromium.content.browser.accessibility.AccessibilityInjector;
 import org.chromium.content.common.TraceEvent;
+import org.chromium.ui.ContainerViewDelegate;
+import org.chromium.ui.NativeView;
 import org.chromium.ui.gfx.NativeWindow;
 
 import java.lang.annotation.Annotation;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.Map;
 
 /**
  * Provides a Java-side 'wrapper' around a WebContent (native) instance.
  * Contains all the major functionality necessary to manage the lifecycle of a ContentView without
@@ skipping 177 matching lines @@
     private final Rect mFocusPreOSKViewportRect = new Rect();
 
     private boolean mNeedUpdateOrientationChanged;
 
     // Used to keep track of whether we should try to undo the last zoom-to-textfield operation.
     private boolean mScrolledAndZoomedFocusedEditableNode = false;
 
     // Whether we use hardware-accelerated drawing.
     private boolean mHardwareAccelerated = false;
 
+    private NativeView mNativeView;
+
     /**
      * Constructs a new ContentViewCore. Embedders must call initialize() after constructing
      * a ContentViewCore and before using it.
      *
      * @param context The context used to create this.
      * @param personality The type of ContentViewCore being created.
      */
     public ContentViewCore(Context context, int personality) {
         mContext = context;
 
@@ skipping 43 matching lines @@
      * Returns a delegate that can be used to add and remove views from the ContainerView.
      *
      * NOTE: Use with care, as not all ContentViewCore users setup their ContainerView in the same
      * way. In particular, the Android WebView has limitations on what implementation details can
      * be provided via a child view, as they are visible in the API and could introduce
      * compatibility breaks with existing applications. If in doubt, contact the
      * android_webview/OWNERS
      *
      * @return A ContainerViewDelegate that can be used to add and remove views.
      */
-    @CalledByNative
+    @VisibleForTesting
     public ContainerViewDelegate getContainerViewDelegate() {
         return new ContainerViewDelegate() {
             @Override
             public void addViewToContainerView(View view) {
                 mContainerView.addView(view);
             }
 
             @Override
             public void removeViewFromContainerView(View view) {
                 mContainerView.removeView(view);
@@ skipping 154 matching lines @@
         // HW acceleration flag can be set dynamically (Grace is doing this),
         // move this check into onAttachedToWindow(), where we can test for
         // HW support directly.
         mHardwareAccelerated = hasHardwareAcceleration(mContext);
 
         // Input events are delivered at vsync time on JB+.
         boolean inputEventsDeliveredAtVSync =
                 (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN);
 
         mContainerView = containerView;
+        mNativeView = new NativeView(nativeWindow, getContainerViewDelegate());

[joth, 2013/04/12 19:00:48]

not sure we can doing anything about it, but the word 'native' here had my head
spinning a bit. Ultimately this reflects the cross-plat chromium "NativeView"
type def, so native means 'system's built in widget system' but in our java code
native normally means "c++"

hmmmm. In c++ NativeView is type'defed to ViewAndroid. How about we name both
the c++ and java class ViewAndroid? And WindowAndroid, and ViewAndroidDelegate,
etc...
This way it's obvious here that this is a 'chromium' concept, as real android
view's (and classes in general) don't have the word "Android" in their names :)

[nilesh, 2013/04/12 19:07:10]

+1

[aurimas (slooooooooow), 2013/04/12 22:00:41]

Done.

+
         mNativeContentViewCore = nativeInit(mHardwareAccelerated, inputEventsDeliveredAtVSync,
-                nativeWebContents, nativeWindow.getNativePointer());
+                nativeWebContents, mNativeView.getNativePointer(),
+                nativeWindow.getNativePointer());
         mContentSettings = new ContentSettings(
                 this, mNativeContentViewCore, isAccessFromFileURLsGrantedByDefault);
         initializeContainerView(internalDispatcher);
         if (mPersonality == PERSONALITY_VIEW) {
             setAllUserAgentOverridesInHistory();
         }
 
         mAccessibilityInjector = AccessibilityInjector.newInstance(this);
         mAccessibilityInjector.addOrRemoveAccessibilityApisIfNecessary();
 
@@ skipping 131 matching lines @@
     /**
      * Destroy the internal state of the ContentView. This method may only be
      * called after the ContentView has been removed from the view system. No
      * other methods may be called on this ContentView after this method has
      * been called.
      */
     public void destroy() {
         if (mNativeContentViewCore != 0) {
             nativeOnJavaContentViewCoreDestroyed(mNativeContentViewCore);
         }
+        mNativeView.destroy();
         mNativeContentViewCore = 0;
         mContentSettings = null;
         mJavaScriptInterfaces.clear();
         mRetainedJavaScriptObjects.clear();
     }
 
     /**
      * Returns true initially, false after destroy() has been called.
      * It is illegal to call any other public method after destroy().
      */
@@ skipping 1993 matching lines @@
             nativeDetachExternalVideoSurface(mNativeContentViewCore, playerId);
         }
     }
 
     @CalledByNative
     private void requestExternalVideoSurface(int playerId) {
         getContentViewClient().onExternalVideoSurfaceRequested(playerId);
     }
 
     private native int nativeInit(boolean hardwareAccelerated, boolean inputEventsDeliveredAtVSync,
-            int webContentsPtr, int windowAndroidPtr);
+            int webContentsPtr, int viewAndroidPtr, int windowAndroidPtr);
 
     private native void nativeOnJavaContentViewCoreDestroyed(int nativeContentViewCoreImpl);
 
     private native void nativeLoadUrl(
             int nativeContentViewCoreImpl,
             String url,
             int loadUrlType,
             int transitionType,
             int uaOverrideOption,
             String extraHeaders,
@@ skipping 148 matching lines @@
             boolean enableHiding, boolean enableShowing, boolean animate);
 
     private native void nativeShowImeIfNeeded(int nativeContentViewCoreImpl);
 
     private native void nativeAttachExternalVideoSurface(
             int nativeContentViewCoreImpl, int playerId, Surface surface);
 
     private native void nativeDetachExternalVideoSurface(
             int nativeContentViewCoreImpl, int playerId);
 }