Issue 1401743004: Fix floating point data loss in SkPictureShader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1401743004: Fix floating point data loss in SkPictureShader (Closed)

Created:
5 years, 2 months ago by ericrk

Modified:
5 years, 2 months ago

Reviewers:
ericrk1, bsalomon

CC:
reviews_skia.org

Base URL:
https://chromium.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Fix floating point data loss in SkPictureShader SkPictureShader had an invalid use of SkMax32 on two SkScalars which ended up converting the result to an integer which caused us to lose necessary floating point data. BUG=473166 Committed: https://skia.googlesource.com/skia/+/f469fc0e0f04197f19c94c26801ba6888c6329dc

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/core/SkPictureShader.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1401743004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1401743004/1

5 years, 2 months ago (2015-10-15 00:26:47 UTC) #5

commit-bot: I haz the power

5 years, 2 months ago (2015-10-15 00:33:33 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f469fc0e0f04197f19c94c26801ba6888c6329dc

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages