Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: components/autofill/core/common/password_form_fill_data.cc

Issue 1401723002: Show source of affiliated matches in the drop-down password suggestions list. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/common/password_form_fill_data.cc
diff --git a/components/autofill/core/common/password_form_fill_data.cc b/components/autofill/core/common/password_form_fill_data.cc
index 36000f8743c40f5d94c5adea59cb38bbf5cb7624..5eb713da1921d9dd10da3de7dbfe14df7a9dd688 100644
--- a/components/autofill/core/common/password_form_fill_data.cc
+++ b/components/autofill/core/common/password_form_fill_data.cc
@@ -58,7 +58,8 @@ void InitPasswordFormFillData(
result->is_possible_change_password_form =
form_on_page.IsPossibleChangePasswordForm();
- if (preferred_match->is_public_suffix_match || preferred_match->is_affiliated)
+ if (preferred_match->is_public_suffix_match ||
+ preferred_match->is_affiliation_based_match)
result->preferred_realm = preferred_match->signon_realm;
// Copy additional username/value pairs.
@@ -67,7 +68,8 @@ void InitPasswordFormFillData(
if (iter->second != preferred_match) {
PasswordAndRealm value;
value.password = iter->second->password_value;
- if (iter->second->is_public_suffix_match)
+ if (iter->second->is_public_suffix_match ||
+ iter->second->is_affiliation_based_match)
value.realm = iter->second->signon_realm;
result->additional_logins[iter->first] = value;
}
@@ -80,7 +82,8 @@ void InitPasswordFormFillData(
UsernamesCollectionKey key;
key.username = iter->first;
key.password = iter->second->password_value;
- if (iter->second->is_public_suffix_match)
+ if (iter->second->is_public_suffix_match ||
+ iter->second->is_affiliation_based_match)
key.realm = iter->second->signon_realm;
result->other_possible_usernames[key] =
iter->second->other_possible_usernames;

Powered by Google App Engine
This is Rietveld 408576698