Issue 1401713002: Rename [packages] to [packageMap] as Isolate.spawnUri parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1401713002: Rename [packages] to [packageMap] as Isolate.spawnUri parameter. (Closed)

Created:
5 years, 2 months ago by Lasse Reichstein Nielsen

Modified:
5 years, 2 months ago

Reviewers:
Siggi Cherem (dart-lang), kevmoo, floitsch

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva, Siggi Cherem (dart-lang)

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Rename [packages] to [packageMap] as Isolate.spawnUri parameter. This matches the static [packageMap] getter on Isolate. Fixes issue #24545. BUG= http://dartbug.com/24545 R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/57f4827c7684e0afc466cd035a9bb3ecaa6d2fd7

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -10 lines)			Patch
M	CHANGELOG.md	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/lib/isolate_patch.dart	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/js_runtime/lib/isolate_patch.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/isolate/isolate.dart	View	1 2	4 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 6 (2 generated)

Lasse Reichstein Nielsen

Committed patchset #3 (id:40001) manually as 57f4827c7684e0afc466cd035a9bb3ecaa6d2fd7 (presubmit successful).

5 years, 2 months ago (2015-10-12 14:32:10 UTC) #4

Message was sent while issue was closed.

lgtm