Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 14017013: Initialize CrosSettings before SetupMetrics (Closed)

Created:
7 years, 8 months ago by stevenjb
Modified:
7 years, 8 months ago
Reviewers:
sschmitz, xiyuan
CC:
chromium-reviews
Visibility:
Public.

Description

Initialize CrosSettings before SetupMetrics BUG=222681 For browser_process_impl.cc: TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194708

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M chrome/browser/browser_process_impl.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
stevenjb
7 years, 8 months ago (2013-04-17 21:47:14 UTC) #1
stevenjb
7 years, 8 months ago (2013-04-17 21:57:46 UTC) #2
xiyuan
lgtm
7 years, 8 months ago (2013-04-17 22:00:35 UTC) #3
stevenjb
7 years, 8 months ago (2013-04-17 23:03:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r194708 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698